Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2297)

Unified Diff: content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc

Issue 1378353006: Implementation of dwrite font proxy and removal of dwrite font cache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More codereview fixes. Jumped the gun on previous patchset. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc
diff --git a/content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc b/content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5996f273372841fb4456768f5faf92f0f239f729
--- /dev/null
+++ b/content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc
@@ -0,0 +1,371 @@
+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/child/dwrite_font_proxy/dwrite_font_proxy_win.h"
+
+#include <dwrite.h>
+#include <shlobj.h>
+#include <wrl.h>
+
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "content/common/dwrite_font_proxy_messages.h"
+#include "content/common/view_messages.h"
+#include "content/test/dwrite_font_fake_sender_win.h"
+#include "ipc/ipc_message_macros.h"
+#include "ipc/ipc_sender.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace mswr = Microsoft::WRL;
+
+namespace content {
+
+void CreateDWriteFactory(IUnknown** factory) {
+ using DWriteCreateFactoryProc = decltype(DWriteCreateFactory)*;
+ HMODULE dwrite_dll = LoadLibraryW(L"dwrite.dll");
+ if (!dwrite_dll)
+ return;
+
+ DWriteCreateFactoryProc dwrite_create_factory_proc =
+ reinterpret_cast<DWriteCreateFactoryProc>(
+ GetProcAddress(dwrite_dll, "DWriteCreateFactory"));
+ if (!dwrite_create_factory_proc)
+ return;
+
+ dwrite_create_factory_proc(DWRITE_FACTORY_TYPE_SHARED,
+ __uuidof(IDWriteFactory), factory);
+}
+
+class DWriteFontProxyUnitTest : public testing::Test {
+ public:
+ DWriteFontProxyUnitTest() {
+ if (factory == nullptr)
+ return;
+ fake_collection_ = new FakeFontCollection();
+ SetupFonts(fake_collection_.get());
+ mswr::MakeAndInitialize<DWriteFontCollectionProxy>(
+ &collection_, factory.Get(),
+ base::Bind(&FakeFontCollection::GetTrackingSender, fake_collection_));
+ }
+
+ ~DWriteFontProxyUnitTest() { collection_->Unregister(); }
+
+ static void SetupFonts(FakeFontCollection* fonts) {
+ fonts->AddFont(L"Aardvark")
+ .AddFamilyName(L"en-us", L"Aardvark")
+ .AddFamilyName(L"de-de", L"Erdferkel")
+ .AddFilePath(L"X:\\Nonexistent\\Folder\\Aardvark.ttf");
+ FakeFont& arial =
+ fonts->AddFont(L"Arial").AddFamilyName(L"en-us", L"Arial");
+ for (auto& path : arial_font_files)
+ arial.AddFilePath(path);
+ fonts->AddFont(L"Times New Roman")
+ .AddFamilyName(L"en-us", L"Times New Roman")
+ .AddFilePath(L"X:\\Nonexistent\\Folder\\Times.ttf");
+ }
+
+ static void SetUpTestCase() {
+ CreateDWriteFactory(&factory);
+
+ std::vector<base::char16> font_path;
+ font_path.resize(MAX_PATH);
+ SHGetSpecialFolderPath(NULL /* hwndOwner - reserved */, font_path.data(),
+ CSIDL_FONTS, FALSE /* fCreate*/);
+ base::string16 arial;
+ arial.append(font_path.data()).append(L"\\arial.ttf");
+ base::string16 arialbd;
+ arialbd.append(font_path.data()).append(L"\\arialbd.ttf");
+ arial_font_files.push_back(arial);
+ arial_font_files.push_back(arialbd);
+ }
+
+ protected:
+ scoped_refptr<FakeFontCollection> fake_collection_;
+ mswr::ComPtr<DWriteFontCollectionProxy> collection_;
+
+ static std::vector<base::string16> arial_font_files;
+ static mswr::ComPtr<IDWriteFactory> factory;
+};
+std::vector<base::string16> DWriteFontProxyUnitTest::arial_font_files;
+mswr::ComPtr<IDWriteFactory> DWriteFontProxyUnitTest::factory;
+
+TEST_F(DWriteFontProxyUnitTest, GetFontFamilyCount) {
+ if (factory == nullptr)
+ return;
+
+ uint32 family_count = collection_->GetFontFamilyCount();
+
+ EXPECT_EQ(3, family_count);
+ ASSERT_EQ(1, fake_collection_->MessageCount());
+ EXPECT_EQ(DWriteFontProxyMsg_GetFamilyCount::ID,
+ fake_collection_->GetMessage(0)->type());
+
+ // Calling again should not cause another message to be sent.
+ family_count = collection_->GetFontFamilyCount();
+ EXPECT_EQ(3, family_count);
+ ASSERT_EQ(1, fake_collection_->MessageCount());
+}
+
+TEST_F(DWriteFontProxyUnitTest, FindFamilyNameShouldFindFamily) {
+ HRESULT hr;
+ if (factory == nullptr)
+ return;
+
+ uint32 index = UINT_MAX;
+ BOOL exists = FALSE;
+ hr = collection_->FindFamilyName(L"Arial", &index, &exists);
+
+ EXPECT_EQ(S_OK, hr);
+ EXPECT_EQ(1, index);
+ EXPECT_TRUE(exists);
+ ASSERT_EQ(2, fake_collection_->MessageCount());
+ EXPECT_EQ(DWriteFontProxyMsg_FindFamily::ID,
+ fake_collection_->GetMessage(0)->type());
+ EXPECT_EQ(DWriteFontProxyMsg_GetFamilyCount::ID,
+ fake_collection_->GetMessage(1)->type());
+}
+
+TEST_F(DWriteFontProxyUnitTest, FindFamilyNameShouldReturnUINTMAXWhenNotFound) {
+ HRESULT hr;
+ if (factory == nullptr)
+ return;
+
+ uint32 index = UINT_MAX;
+ BOOL exists = FALSE;
+ hr = collection_->FindFamilyName(L"Not a font", &index, &exists);
+
+ EXPECT_EQ(S_OK, hr);
+ EXPECT_EQ(UINT32_MAX, index);
+ EXPECT_FALSE(exists);
+ ASSERT_EQ(1, fake_collection_->MessageCount());
+ EXPECT_EQ(DWriteFontProxyMsg_FindFamily::ID,
+ fake_collection_->GetMessage(0)->type());
+}
+
+TEST_F(DWriteFontProxyUnitTest, FindFamilyNameShouldNotSendDuplicateIPC) {
+ HRESULT hr;
+ if (factory == nullptr)
+ return;
+
+ uint32 index = UINT_MAX;
+ BOOL exists = FALSE;
+ hr = collection_->FindFamilyName(L"Arial", &index, &exists);
+ ASSERT_EQ(S_OK, hr);
+ ASSERT_EQ(2, fake_collection_->MessageCount());
+
+ hr = collection_->FindFamilyName(L"Arial", &index, &exists);
+
+ EXPECT_EQ(S_OK, hr);
+ EXPECT_EQ(2, fake_collection_->MessageCount());
+}
+
+TEST_F(DWriteFontProxyUnitTest, GetFontFamilyShouldCreateFamily) {
+ HRESULT hr;
+ if (factory == nullptr)
+ return;
+
+ uint32 index = UINT_MAX;
+ BOOL exists = FALSE;
+ hr = collection_->FindFamilyName(L"Arial", &index, &exists);
+ ASSERT_EQ(2, fake_collection_->MessageCount());
+
+ mswr::ComPtr<IDWriteFontFamily> family;
+ hr = collection_->GetFontFamily(2, &family);
+
+ EXPECT_EQ(S_OK, hr);
+ EXPECT_EQ(2, fake_collection_->MessageCount());
+ EXPECT_NE(nullptr, family.Get());
+}
+
+void CheckLocale(IDWriteLocalizedStrings* strings,
+ const base::string16& locale_name,
+ const base::string16& expected_value) {
+ UINT32 locale_index = 0;
+ BOOL locale_exists = FALSE;
+ strings->FindLocaleName(locale_name.data(), &locale_index, &locale_exists);
+ EXPECT_TRUE(locale_exists);
+
+ UINT32 name_length = 0;
+ strings->GetLocaleNameLength(locale_index, &name_length);
+ EXPECT_EQ(locale_name.size(), name_length);
+ base::string16 actual_name;
+ name_length++;
+ actual_name.resize(name_length);
+ strings->GetLocaleName(locale_index, const_cast<WCHAR*>(actual_name.data()),
+ name_length);
+ EXPECT_STREQ(locale_name.c_str(), actual_name.c_str());
+
+ UINT32 string_length = 0;
+ strings->GetStringLength(locale_index, &string_length);
+ EXPECT_EQ(expected_value.size(), string_length);
+ base::string16 actual_value;
+ string_length++;
+ actual_value.resize(string_length);
+ strings->GetString(locale_index, const_cast<WCHAR*>(actual_value.data()),
+ string_length);
+ EXPECT_STREQ(expected_value.c_str(), actual_value.c_str());
+}
+
+TEST_F(DWriteFontProxyUnitTest, GetFamilyNames) {
+ HRESULT hr;
+ if (factory == nullptr)
+ return;
+
+ uint32 index = UINT_MAX;
+ BOOL exists = FALSE;
+ hr = collection_->FindFamilyName(L"Aardvark", &index, &exists);
+ ASSERT_EQ(2, fake_collection_->MessageCount());
+
+ mswr::ComPtr<IDWriteFontFamily> family;
+ hr = collection_->GetFontFamily(index, &family);
+ EXPECT_EQ(S_OK, hr);
+ EXPECT_EQ(2, fake_collection_->MessageCount());
+
+ mswr::ComPtr<IDWriteLocalizedStrings> names;
+ hr = family->GetFamilyNames(&names);
+ EXPECT_EQ(S_OK, hr);
+ EXPECT_EQ(3, fake_collection_->MessageCount());
+ EXPECT_EQ(DWriteFontProxyMsg_GetFamilyNames::ID,
+ fake_collection_->GetMessage(2)->type());
+
+ EXPECT_EQ(2, names->GetCount());
+ UINT32 locale_index = 0;
+ BOOL locale_exists = FALSE;
+ hr = names->FindLocaleName(L"fr-fr", &locale_index, &locale_exists);
+ EXPECT_EQ(S_OK, hr);
+ EXPECT_FALSE(locale_exists);
+
+ CheckLocale(names.Get(), L"en-us", L"Aardvark");
+ CheckLocale(names.Get(), L"de-de", L"Erdferkel");
+
+ base::string16 unused;
+ unused.resize(25);
+ hr = names->GetLocaleName(15234, const_cast<WCHAR*>(unused.data()),
+ unused.size() - 1);
+ EXPECT_FALSE(SUCCEEDED(hr));
+}
+
+TEST_F(DWriteFontProxyUnitTest, GetFontCollection) {
+ HRESULT hr;
+ if (factory == nullptr)
+ return;
+
+ uint32 index = UINT_MAX;
+ BOOL exists = FALSE;
+ hr = collection_->FindFamilyName(L"Arial", &index, &exists);
+ ASSERT_EQ(2, fake_collection_->MessageCount());
+
+ mswr::ComPtr<IDWriteFontFamily> family;
+ hr = collection_->GetFontFamily(2, &family);
+ EXPECT_EQ(S_OK, hr);
+ EXPECT_EQ(2, fake_collection_->MessageCount());
+
+ mswr::ComPtr<IDWriteFontCollection> returned_collection;
+ hr = family->GetFontCollection(&returned_collection);
+ EXPECT_EQ(S_OK, hr);
+ EXPECT_EQ(2, fake_collection_->MessageCount());
+ EXPECT_EQ(collection_.Get(), returned_collection.Get());
+}
+
+TEST_F(DWriteFontProxyUnitTest, GetFamilyNamesShouldNotIPCAfterLoadingFamily) {
+ HRESULT hr;
+ if (factory == nullptr)
+ return;
+
+ uint32 index = UINT_MAX;
+ BOOL exists = FALSE;
+ collection_->FindFamilyName(L"Arial", &index, &exists);
+ mswr::ComPtr<IDWriteFontFamily> family;
+ collection_->GetFontFamily(index, &family);
+ family->GetFontCount();
+ EXPECT_EQ(fake_collection_->MessageCount(), 3);
+
+ mswr::ComPtr<IDWriteLocalizedStrings> names;
+ hr = family->GetFamilyNames(&names);
+ EXPECT_EQ(S_OK, hr);
+ EXPECT_EQ(3, fake_collection_->MessageCount());
+}
+
+TEST_F(DWriteFontProxyUnitTest,
+ GetFontFamilyShouldNotCreateFamilyWhenIndexIsInvalid) {
+ HRESULT hr;
+ if (factory == nullptr)
+ return;
+
+ uint32 index = UINT_MAX;
+ BOOL exists = FALSE;
+ hr = collection_->FindFamilyName(L"Arial", &index, &exists);
+ ASSERT_EQ(2, fake_collection_->MessageCount());
+
+ mswr::ComPtr<IDWriteFontFamily> family;
+ hr = collection_->GetFontFamily(1654, &family);
+
+ EXPECT_FALSE(SUCCEEDED(hr));
+ EXPECT_EQ(2, fake_collection_->MessageCount());
+}
+
+TEST_F(DWriteFontProxyUnitTest, LoadingFontFamily) {
+ HRESULT hr;
+ if (factory == nullptr)
+ return;
+
+ uint32 index = UINT_MAX;
+ BOOL exists = FALSE;
+ collection_->FindFamilyName(L"Arial", &index, &exists);
+ mswr::ComPtr<IDWriteFontFamily> family;
+ collection_->GetFontFamily(index, &family);
+ ASSERT_EQ(2, fake_collection_->MessageCount());
+
+ UINT32 font_count = family->GetFontCount();
+ EXPECT_LT(0u, font_count);
+ EXPECT_EQ(3, fake_collection_->MessageCount());
+ EXPECT_EQ(DWriteFontProxyMsg_GetFontFiles::ID,
+ fake_collection_->GetMessage(2)->type());
+ mswr::ComPtr<IDWriteFont> font;
+ hr = family->GetFirstMatchingFont(DWRITE_FONT_WEIGHT_NORMAL,
+ DWRITE_FONT_STRETCH_NORMAL,
+ DWRITE_FONT_STYLE_NORMAL, &font);
+ EXPECT_EQ(S_OK, hr);
+ EXPECT_EQ(3, fake_collection_->MessageCount());
+ mswr::ComPtr<IDWriteFont> font2;
+ hr = family->GetFont(0, &font2);
+ EXPECT_EQ(S_OK, hr);
+ EXPECT_EQ(3, fake_collection_->MessageCount());
+ mswr::ComPtr<IDWriteFontList> matching_fonts;
+ hr = family->GetMatchingFonts(DWRITE_FONT_WEIGHT_NORMAL,
+ DWRITE_FONT_STRETCH_NORMAL,
+ DWRITE_FONT_STYLE_NORMAL, &matching_fonts);
+ EXPECT_EQ(S_OK, hr);
+ EXPECT_EQ(3, fake_collection_->MessageCount());
+ EXPECT_NE(nullptr, matching_fonts.Get());
+}
+
+TEST_F(DWriteFontProxyUnitTest, GetFontFromFontFaceShouldFindFont) {
+ HRESULT hr;
+ if (factory == nullptr)
+ return;
+
+ uint32 index = UINT_MAX;
+ BOOL exists = FALSE;
+ collection_->FindFamilyName(L"Arial", &index, &exists);
+ mswr::ComPtr<IDWriteFontFamily> family;
+ collection_->GetFontFamily(index, &family);
+
+ mswr::ComPtr<IDWriteFont> font;
+ family->GetFirstMatchingFont(DWRITE_FONT_WEIGHT_NORMAL,
+ DWRITE_FONT_STRETCH_NORMAL,
+ DWRITE_FONT_STYLE_NORMAL, &font);
+
+ mswr::ComPtr<IDWriteFontFace> font_face;
+ hr = font->CreateFontFace(&font_face);
+ ASSERT_TRUE(SUCCEEDED(hr));
+ ASSERT_EQ(3, fake_collection_->MessageCount());
+
+ mswr::ComPtr<IDWriteFont> found_font;
+ collection_->GetFontFromFontFace(font_face.Get(), &found_font);
+ EXPECT_NE(nullptr, found_font.Get());
+ EXPECT_EQ(3, fake_collection_->MessageCount());
+}
+
+} // namespace content

Powered by Google App Engine
This is Rietveld 408576698