Issue 1378343002: Add access check to JSObject::IsExtensible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1378343002: Add access check to JSObject::IsExtensible. (Closed)

Created:
5 years, 2 months ago by neis

Modified:
5 years, 2 months ago

Reviewers:
Toon Verwaest

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Add access check to JSObject::IsExtensible. R=verwaest@chromium.org BUG= Committed: https://crrev.com/ce08f45b1b2047ec07adfedb673b603cba4bde01 Cr-Commit-Position: refs/heads/master@{#31055}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -9 lines)			Patch
M	src/objects.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	2 chunks	+10 lines, -5 lines	0 comments	Download
M	src/runtime/runtime-object.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Toon Verwaest

Awesome, lgtm! Thanks for discovering and fixing this missing piece.

5 years, 2 months ago (2015-10-01 15:24:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378343002/1

5 years, 2 months ago (2015-10-01 15:25:29 UTC) #4

commit-bot: I haz the power

5 years, 2 months ago (2015-10-01 16:10:19 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ce08f45b1b2047ec07adfedb673b603cba4bde01
Cr-Commit-Position: refs/heads/master@{#31055}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages