Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: Source/core/dom/Element.h

Issue 137833018: Remove form control related virtual methods from Element (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add HTMLFormControlElement.setFocus as suggested Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/html/HTMLFormControlElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2013 Appl e Inc. All rights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2013 Appl e Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 451 matching lines...) Expand 10 before | Expand all | Expand 10 after
462 virtual bool willValidate() const { return false; } 462 virtual bool willValidate() const { return false; }
463 virtual bool isValidFormControlElement() { return false; } 463 virtual bool isValidFormControlElement() { return false; }
464 virtual bool isInRange() const { return false; } 464 virtual bool isInRange() const { return false; }
465 virtual bool isOutOfRange() const { return false; } 465 virtual bool isOutOfRange() const { return false; }
466 virtual bool isFrameElementBase() const { return false; } 466 virtual bool isFrameElementBase() const { return false; }
467 virtual bool isPasswordGeneratorButtonElement() const { return false; } 467 virtual bool isPasswordGeneratorButtonElement() const { return false; }
468 virtual bool isClearButtonElement() const { return false; } 468 virtual bool isClearButtonElement() const { return false; }
469 469
470 virtual bool canContainRangeEndPoint() const OVERRIDE { return true; } 470 virtual bool canContainRangeEndPoint() const OVERRIDE { return true; }
471 471
472 virtual const AtomicString& formControlType() const { return nullAtom; }
473
474 // FIXME: Only HTMLInputElement uses these, they don't need to be virtual.
475 virtual bool wasChangedSinceLastFormControlChangeEvent() const { return fals e; }
476 virtual void setChangedSinceLastFormControlChangeEvent(bool) { }
477 virtual void dispatchFormControlChangeEvent() { }
478
479 // Used for disabled form elements; if true, prevents mouse events from bein g dispatched 472 // Used for disabled form elements; if true, prevents mouse events from bein g dispatched
480 // to event listeners, and prevents DOMActivate events from being sent at al l. 473 // to event listeners, and prevents DOMActivate events from being sent at al l.
481 virtual bool isDisabledFormControl() const { return false; } 474 virtual bool isDisabledFormControl() const { return false; }
482 475
483 bool hasPendingResources() const; 476 bool hasPendingResources() const;
484 void setHasPendingResources(); 477 void setHasPendingResources();
485 void clearHasPendingResources(); 478 void clearHasPendingResources();
486 virtual void buildPendingResource() { }; 479 virtual void buildPendingResource() { };
487 480
488 enum { 481 enum {
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
891 } 884 }
892 885
893 inline bool isShadowHost(const Element* element) 886 inline bool isShadowHost(const Element* element)
894 { 887 {
895 return element && element->shadow(); 888 return element && element->shadow();
896 } 889 }
897 890
898 } // namespace 891 } // namespace
899 892
900 #endif 893 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/html/HTMLFormControlElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698