Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137833016: add SkCanvas constructor that explicitly creates no_config with dimensions (Closed)

Created:
6 years, 10 months ago by reed1
Modified:
6 years, 10 months ago
Reviewers:
hal.canary, scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

add SkCanvas constructor that explicitly creates no_config with dimensions BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13272

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -37 lines) Patch
M include/core/SkCanvas.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 1 chunk +17 lines, -4 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 1 1 chunk +2 lines, -8 lines 0 comments Download
M src/utils/SkLuaCanvas.cpp View 1 1 chunk +1 line, -7 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 1 1 chunk +1 line, -7 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 1 1 chunk +1 line, -7 lines 0 comments Download
M tests/PictureTest.cpp View 1 2 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
reed1
6 years, 10 months ago (2014-01-31 18:50:07 UTC) #1
scroggo
lgtm https://codereview.chromium.org/137833016/diff/20001/tests/PictureTest.cpp File tests/PictureTest.cpp (right): https://codereview.chromium.org/137833016/diff/20001/tests/PictureTest.cpp#newcode926 tests/PictureTest.cpp:926: : SkCanvas(width, height) nit: INHERITED
6 years, 10 months ago (2014-01-31 18:59:23 UTC) #2
reed1
On 2014/01/31 18:59:23, scroggo wrote: > lgtm > > https://codereview.chromium.org/137833016/diff/20001/tests/PictureTest.cpp > File tests/PictureTest.cpp (right): > ...
6 years, 10 months ago (2014-01-31 19:33:11 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 10 months ago (2014-01-31 19:34:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/137833016/90001
6 years, 10 months ago (2014-01-31 19:34:12 UTC) #5
commit-bot: I haz the power
Change committed as 13272
6 years, 10 months ago (2014-01-31 19:43:02 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 19:43:04 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-01-31 19:43:08 UTC) #8
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698