chrome/browser/search_engines/search_provider_install_data.cc - Issue 137833009: Fix use after free in SearchProviderInstallData GoogleURLObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search_engines/search_provider_install_data.cc

Issue 137833009: Fix use after free in SearchProviderInstallData GoogleURLObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/search_engines/search_provider_install_data.cc

diff --git a/chrome/browser/search_engines/search_provider_install_data.cc b/chrome/browser/search_engines/search_provider_install_data.cc

index 64b14fdebde2dde07e9148a52bbde1b54d027017..dd05a99f72f93b29bd2eeabcc57a459ac8f96eec 100644

--- a/chrome/browser/search_engines/search_provider_install_data.cc

+++ b/chrome/browser/search_engines/search_provider_install_data.cc

@@ -146,6 +146,7 @@ void GoogleURLObserver::Observe(int type,

void GoogleURLObserver::RenderProcessHostDestroyed(

content::RenderProcessHost* host) {

+ host->RemoveObserver(this);

delete this;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »