Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 137833004: Clamp negative sigma to 0 in SkDropShadowImageFilter. (Closed)

Created:
6 years, 10 months ago by Stephen White
Modified:
6 years, 10 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Clamp negative sigma to 0 in SkDropShadowImageFilter. This can occur when the matrix includes a perspective transform. BUG=skia:2094 R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=13220

Patch Set 1 #

Patch Set 2 : Use SkMaxScalar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/effects/SkDropShadowImageFilter.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Stephen White
6 years, 10 months ago (2014-01-28 17:49:18 UTC) #1
Stephen White
PTAL. Thanks!
6 years, 10 months ago (2014-01-28 17:49:26 UTC) #2
bsalomon
On 2014/01/28 17:49:26, Stephen White wrote: > PTAL. Thanks! lgtm, but style nit if (sigma.fX ...
6 years, 10 months ago (2014-01-28 17:51:05 UTC) #3
Stephen White
On 2014/01/28 17:51:05, bsalomon wrote: > On 2014/01/28 17:49:26, Stephen White wrote: > > PTAL. ...
6 years, 10 months ago (2014-01-28 17:54:47 UTC) #4
bsalomon
lgtm
6 years, 10 months ago (2014-01-28 17:57:17 UTC) #5
Stephen White
6 years, 10 months ago (2014-01-28 17:57:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r13220 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698