Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1333)

Side by Side Diff: test/mjsunit/global-properties.js

Issue 1378323003: [runtime-object]: part fix element key list on global object (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fixing nits Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-global-object.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 var global = this; 28 var global = this;
29 29
30 function f0(x) { 30 function testNamedProperty(key, value) {
31 assertTrue(this === global); 31 global[key] = value;
32 return x; 32 assertTrue(global.hasOwnProperty(key));
33 assertTrue(-1 < Object.keys(global).indexOf(key));
34 assertTrue(-1 < Object.getOwnPropertyNames(global).indexOf(key));
35 assertTrue(-1 == Object.getOwnPropertySymbols(global).indexOf(key));
33 } 36 }
34 37
35 function g0(x, y) { 38 testNamedProperty('property0', 'value');
36 return f0(x == y); 39 testNamedProperty('0property', 'value');
40 testNamedProperty('42', 'value');
41
42 function testNamedNonEnumerableProperty(key, value) {
43 Object.defineProperty(global, key, {
44 enumerable: false,
45 value: value
46 });
47 assertTrue(global.hasOwnProperty(key));
48 assertTrue(-1 == Object.keys(global).indexOf(key));
49 assertTrue(-1 < Object.getOwnPropertyNames(global).indexOf(key));
50 assertTrue(-1 == Object.getOwnPropertySymbols(global).indexOf(key));
37 } 51 }
38 52
39 assertTrue(g0(0, 0)); 53 testNamedNonEnumerableProperty('property1', 'value');
40 assertFalse(g0(0, 1)); 54 testNamedNonEnumerableProperty('1property', 'value');
55 testNamedNonEnumerableProperty('43', 'value');
41 56
42 57 function testSymbolProperty(key, value) {
43 var o = {}; 58 key = Symbol(key);
44 o.f1 = f1; 59 global[key] = value;
45 function f1(x) { 60 assertTrue(global.hasOwnProperty(key));
46 assertTrue(this === o); 61 assertTrue(-1 == Object.keys(global).indexOf(key));
47 return x; 62 assertTrue(-1 == Object.getOwnPropertyNames(global).indexOf(key));
63 assertTrue(-1 < Object.getOwnPropertySymbols(global).indexOf(key));
48 } 64 }
49 65
50 function g1(x, y) { 66 testSymbolProperty('property2', 'value');
51 return o.f1(x == y); 67 testSymbolProperty('2property', 'value');
52 } 68 testSymbolProperty('43', 'value');
53
54 assertTrue(g1(0, 0));
55 assertFalse(g1(0, 1));
OLDNEW
« no previous file with comments | « test/cctest/test-global-object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698