Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1378323003: [runtime-object]: part fix element key list on global object (Closed)

Created:
5 years, 2 months ago by Camillo Bruni
Modified:
5 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime-object]: part fix element key list on global object BUG=v8:2764 LOG=N R=verwaest@chromium.org Committed: https://crrev.com/cfd417202e499b49f7a17a8380775aa375078625 Cr-Commit-Position: refs/heads/master@{#31099}

Patch Set 1 #

Total comments: 1

Patch Set 2 : respecting detached global proxy #

Patch Set 3 : null vs undefined #

Patch Set 4 : adding cctests #

Total comments: 2

Patch Set 5 : fixing nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -23 lines) Patch
M src/runtime/runtime-object.cc View 1 2 3 1 chunk +15 lines, -3 lines 0 comments Download
M test/cctest/test-global-object.cc View 1 2 3 4 2 chunks +51 lines, -1 line 0 comments Download
A + test/mjsunit/global-properties.js View 1 2 3 4 1 chunk +32 lines, -19 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378323003/1
5 years, 2 months ago (2015-10-01 13:34:42 UTC) #2
Camillo Bruni
PTAL
5 years, 2 months ago (2015-10-01 13:46:16 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-01 13:57:31 UTC) #5
Toon Verwaest
Mostly looking good, but you missed a cornercase you surely didn't know about. https://codereview.chromium.org/1378323003/diff/1/src/runtime/runtime-object.cc File ...
5 years, 2 months ago (2015-10-01 15:22:47 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378323003/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378323003/50001
5 years, 2 months ago (2015-10-05 08:47:38 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-05 09:11:02 UTC) #10
Camillo Bruni
PTAL - added cctests - using PrototypeIterator directly to check for missing prototype
5 years, 2 months ago (2015-10-05 09:25:30 UTC) #11
Toon Verwaest
lgtm with nits https://codereview.chromium.org/1378323003/diff/50001/test/cctest/test-global-object.cc File test/cctest/test-global-object.cc (right): https://codereview.chromium.org/1378323003/diff/50001/test/cctest/test-global-object.cc#newcode89 test/cctest/test-global-object.cc:89: // ExpectTrue("global2.hasOwnProperty('42')"); Leftover tests? https://codereview.chromium.org/1378323003/diff/50001/test/mjsunit/global-properties.js File ...
5 years, 2 months ago (2015-10-05 11:14:32 UTC) #12
Camillo Bruni
5 years, 2 months ago (2015-10-05 14:01:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378323003/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378323003/70001
5 years, 2 months ago (2015-10-05 14:01:20 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:70001)
5 years, 2 months ago (2015-10-05 14:23:14 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 14:23:34 UTC) #18
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/cfd417202e499b49f7a17a8380775aa375078625
Cr-Commit-Position: refs/heads/master@{#31099}

Powered by Google App Engine
This is Rietveld 408576698