Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1378303003: Subzero. Adds ldrex, strex, and dmb support (ARM32) (Closed)

Created:
5 years, 2 months ago by John
Modified:
5 years, 2 months ago
Reviewers:
Jim Stichnoth, Karl, sehr
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero. Adds ldrex, strex, and dmb support (ARM32) These instructions are used to load/store data atomically, and to notify the processor about a data memory barrier. They are used for implementing the llvm.nacl.atomic.* lowerings. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=16991847500a48932426d979c4f2d4adffaf3649

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addresses comments. #

Patch Set 3 : merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -18 lines) Patch
M src/IceInstARM32.h View 8 chunks +62 lines, -18 lines 0 comments Download
M src/IceInstARM32.cpp View 1 7 chunks +95 lines, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.h View 3 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
John
5 years, 2 months ago (2015-10-01 20:57:20 UTC) #2
Jim Stichnoth
lgtm https://chromiumcodereview.appspot.com/1378303003/diff/1/src/IceInstARM32.cpp File src/IceInstARM32.cpp (right): https://chromiumcodereview.appspot.com/1378303003/diff/1/src/IceInstARM32.cpp#newcode1 src/IceInstARM32.cpp:1: //===----------------------------------------------------------------------===// Why was this changed?
5 years, 2 months ago (2015-10-01 21:46:47 UTC) #3
John
Committed patchset #3 (id:40001) manually as 16991847500a48932426d979c4f2d4adffaf3649 (presubmit successful).
5 years, 2 months ago (2015-10-01 22:11:27 UTC) #4
John
5 years, 2 months ago (2015-10-01 22:11:45 UTC) #5
Message was sent while issue was closed.
https://chromiumcodereview.appspot.com/1378303003/diff/1/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://chromiumcodereview.appspot.com/1378303003/diff/1/src/IceInstARM32.cpp...
src/IceInstARM32.cpp:1:
//===----------------------------------------------------------------------===//
On 2015/10/01 21:46:47, stichnot wrote:
> Why was this changed?

Done.

Powered by Google App Engine
This is Rietveld 408576698