Decouple CookieMonsterTest from CookieStoreTest.

Decouple CookieMonsterTest from CookieStoreTest.

Prior implementation had CookieMonsterTest hard-coded to be aware
of specific parts (domain, etc.) of CookieStoreTest's test URL's.

This change switches CookieStoreTest's URL's from GURL to a new URLHelper
which has methods for these tests so that the desired parts of the URL's
from CookieStoreTest can be extracted, or new variants can be created.

Committed: https://crrev.com/8688a8f8c4f3e2010d5a6ecf7cc928121f7a4340
Cr-Commit-Position: refs/heads/master@{#354304}

[cmumford, 2015-10-06 18:00:52]

cmumford@chromium.org changed reviewers:
+ mkwst@chromium.org

[cmumford, 2015-10-06 18:00:53]

A reviewer in another CL had commented on the unnecessary coupling between these
two classes. I decided to take a swag at fixing this.

[Mike West, 2015-10-09 15:02:39]

The CQ bit was checked by mkwst@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-09 15:05:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1378273003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1378273003/1

[Mike West, 2015-10-09 15:08:16]

Conceptually, I think this is fine, but the URLHelper implementation need a
little bit of work. Thanks for taking a look! Comments inline.

https://codereview.chromium.org/1378273003/diff/1/net/cookies/cookie_store_un...
File net/cookies/cookie_store_unittest.h (right):

https://codereview.chromium.org/1378273003/diff/1/net/cookies/cookie_store_un...
net/cookies/cookie_store_unittest.h:81: std::vector<std::string> parts =
SplitString(
This constructor should be in a `.cc` file.

https://codereview.chromium.org/1378273003/diff/1/net/cookies/cookie_store_un...
net/cookies/cookie_store_unittest.h:85: domain_ = base::JoinString(parts, ".");
I think you're trying to get the registerable domain here? I'd suggest using
something like `net::registry_controlled_domains` to do this work.

https://codereview.chromium.org/1378273003/diff/1/net/cookies/cookie_store_un...
net/cookies/cookie_store_unittest.h:86: tld_ = parts[1];
This isn't how TLDs work. Consider `co.uk`, for example. :)

https://codereview.chromium.org/1378273003/diff/1/net/cookies/cookie_store_un...
net/cookies/cookie_store_unittest.h:97: std::string new_string = format_string;
This should also be in a `.cc` file.

[commit-bot: I haz the power, 2015-10-09 15:43:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-09 15:43:55]

Dry run: This issue passed the CQ dry run.

[cmumford, 2015-10-09 21:21:01]

Because URLHelper was nested inside a templated class I decided it was best to
move it outside. cookie_store_test_helpers.cc looks like an appropriate place.

https://codereview.chromium.org/1378273003/diff/1/net/cookies/cookie_store_un...
File net/cookies/cookie_store_unittest.h (right):

https://codereview.chromium.org/1378273003/diff/1/net/cookies/cookie_store_un...
net/cookies/cookie_store_unittest.h:81: std::vector<std::string> parts =
SplitString(
On 2015/10/09 15:08:15, Mike West (slow) wrote:
> This constructor should be in a `.cc` file.

Done.

https://codereview.chromium.org/1378273003/diff/1/net/cookies/cookie_store_un...
net/cookies/cookie_store_unittest.h:85: domain_ = base::JoinString(parts, ".");
On 2015/10/09 15:08:16, Mike West (slow) wrote:
> I think you're trying to get the registerable domain here? I'd suggest using
> something like `net::registry_controlled_domains` to do this work.

Done - thx for that pointer.

https://codereview.chromium.org/1378273003/diff/1/net/cookies/cookie_store_un...
net/cookies/cookie_store_unittest.h:86: tld_ = parts[1];
On 2015/10/09 15:08:16, Mike West (slow) wrote:
> This isn't how TLDs work. Consider `co.uk`, for example. :)
> 

Yeah - I was only trying to satisfy the needs of the test here, but even still
it's both clearer and more robust to use registry_controlled_domains as you
suggested, so Done!

https://codereview.chromium.org/1378273003/diff/1/net/cookies/cookie_store_un...
net/cookies/cookie_store_unittest.h:97: std::string new_string = format_string;
On 2015/10/09 15:08:15, Mike West (slow) wrote:
> This should also be in a `.cc` file.

Done.

[Mike West, 2015-10-15 09:26:50]

Sorry, lost track of this. Patch #2 LGTM.

[cmumford, 2015-10-15 17:08:46]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2015-10-15 17:09:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1378273003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1378273003/20001

[commit-bot: I haz the power, 2015-10-15 18:08:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-15 18:09:29]

Patchset 2 (id:??) landed as
https://crrev.com/8688a8f8c4f3e2010d5a6ecf7cc928121f7a4340
Cr-Commit-Position: refs/heads/master@{#354304}