Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Issue 1378253002: Move strings-storage.* to the profiler directory (Closed)

Created:
5 years, 2 months ago by alph
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, yurys
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move strings-storage.* to the profiler directory Committed: https://crrev.com/0dedff6bf10c160d48a03f48cc0c58431d875530 Cr-Commit-Position: refs/heads/master@{#31060}

Patch Set 1 #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -178 lines) Patch
M BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/profiler/heap-snapshot-generator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/profiler/profile-generator.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + src/profiler/strings-storage.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + src/profiler/strings-storage.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/strings-storage.h View 1 1 chunk +0 lines, -45 lines 0 comments Download
D src/strings-storage.cc View 1 chunk +0 lines, -123 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
alph
5 years, 2 months ago (2015-09-30 23:30:00 UTC) #2
Benedikt Meurer
lgtm
5 years, 2 months ago (2015-10-01 07:14:54 UTC) #3
yurys
lgtm
5 years, 2 months ago (2015-10-01 16:00:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378253002/20001
5 years, 2 months ago (2015-10-01 17:34:40 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-01 18:11:02 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 18:11:12 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0dedff6bf10c160d48a03f48cc0c58431d875530
Cr-Commit-Position: refs/heads/master@{#31060}

Powered by Google App Engine
This is Rietveld 408576698