Issue 1378193006: Merge to XFA: Do not call into formfiller code with a NULL PageView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1378193006: Merge to XFA: Do not call into formfiller code with a NULL PageView. (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Do not call into formfiller code with a NULL PageView. BUG=537173 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1376093002 . (cherry picked from commit ac67d4765a8ac36cd00c9fc8b6f2b80a3e1cff72) Committed: https://pdfium.googlesource.com/pdfium/+/8c217c537fc845763018a5d81a8c55b1045f6ccd

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -16 lines)			Patch
M	fpdfsdk/include/formfiller/FFL_FormFiller.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/formfiller/FFL_FormFiller.cpp	View	2 chunks	+10 lines, -11 lines	0 comments	Download
M	fpdfsdk/src/formfiller/FFL_IFormFiller.cpp	View	2 chunks	+2 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

5 years, 2 months ago (2015-10-04 06:26:14 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8c217c537fc845763018a5d81a8c55b1045f6ccd (presubmit successful).