Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 1378163003: Use initial values for flood/lighting-color/flood-opacity when detached

Created:
5 years, 2 months ago by fs
Modified:
5 years, 2 months ago
Reviewers:
CC:
chromium-reviews, krit, kouhei+svg_chromium.org, fs, f(malita), blink-reviews, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use initial values for flood/lighting-color/flood-opacity when detached This just papers over the fact that external referenced filters don't have layout trees. Prefer something to a failure dictated by lacking implementation. BUG=533457

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -29 lines) Patch
M third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp View 1 chunk +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEFloodElement.cpp View 1 chunk +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFESpecularLightingElement.cpp View 1 chunk +5 lines, -6 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698