Add check to verify alignment on global variables.

Add check to verify alignment on global variables.

Moves the alignment check method from the function block parser, to the
top-level parser, and then uses it to also check alignment on global
variables.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4329
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=07af2ac73b348fb5e6378a49abcc9c9a36775a08

[Karl, 2015-09-30 20:58:16]

kschimpf@google.com changed reviewers:
+ dschuff@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-09-30 21:40:21]

https://chromiumcodereview.appspot.com/1378163002/diff/20001/src/PNaClTransla...
File src/PNaClTranslator.cpp (right):

https://chromiumcodereview.appspot.com/1378163002/diff/20001/src/PNaClTransla...
src/PNaClTranslator.cpp:356: static const uint32_t AlignPowerLimit = 29;
constexpr ?

https://chromiumcodereview.appspot.com/1378163002/diff/20001/src/PNaClTransla...
src/PNaClTranslator.cpp:362: void extractAlignment(NaClBitcodeParser *Parser,
const char *Prefix,
Can this function directly return Alignment instead of setting it in an output
parameter?

[Karl, 2015-09-30 22:23:45]

https://chromiumcodereview.appspot.com/1378163002/diff/20001/src/PNaClTransla...
File src/PNaClTranslator.cpp (right):

https://chromiumcodereview.appspot.com/1378163002/diff/20001/src/PNaClTransla...
src/PNaClTranslator.cpp:356: static const uint32_t AlignPowerLimit = 29;
On 2015/09/30 21:40:21, stichnot wrote:
> constexpr ?

Done.

https://chromiumcodereview.appspot.com/1378163002/diff/20001/src/PNaClTransla...
src/PNaClTranslator.cpp:362: void extractAlignment(NaClBitcodeParser *Parser,
const char *Prefix,
On 2015/09/30 21:40:21, stichnot wrote:
> Can this function directly return Alignment instead of setting it in an output
> parameter?

Done.

[Jim Stichnoth, 2015-09-30 22:26:27]

lgtm

[Karl, 2015-09-30 22:33:44]

Committed patchset #3 (id:40001) manually as
07af2ac73b348fb5e6378a49abcc9c9a36775a08 (presubmit successful).