Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1378153003:
win: Update to Win 10 SDK (Closed)
|
Created:
5 years, 2 months ago by scottmg Modified:
4 years, 10 months ago CC:
chromium-reviews, tfarina, Nico, Jim Stichnoth, Petr Hosek, Karl, Junichi Uekawa, Sam Clegg, cdotstout, Roland McGrath Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionwin: Update to Win 10 SDK
Tested on clean Win7 VM against both VS2013 and clang=1 at 247874-1.
R=brucedawson@chromium.org
BUG=491424
Committed: https://crrev.com/3f6f89251dc210b24a36398237d374a87d4a3b33
Cr-Commit-Position: refs/heads/master@{#352667}
Committed: https://crrev.com/1feffb4b7b1c2bfaf112a8993ae7ab0c16a52da9
Cr-Commit-Position: refs/heads/master@{#356373}
Patch Set 1 #Patch Set 2 : . #Patch Set 3 : . #
Total comments: 1
Patch Set 4 : . #
Total comments: 6
Patch Set 5 : . #Patch Set 6 : rebase #Patch Set 7 : include nacl roll #Patch Set 8 : rebase for reland #
Messages
Total messages: 38 (11 generated)
https://codereview.chromium.org/1378153003/diff/40001/chrome/browser/google/g... File chrome/browser/google/google_update_win.cc (right): https://codereview.chromium.org/1378153003/diff/40001/chrome/browser/google/g... chrome/browser/google/google_update_win.cc:359: allowed_retries_(kGoogleAllowedRetries), This seems unrelated, but is apparently broken on clang at the moment.
https://codereview.chromium.org/1378153003/diff/60001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/1378153003/diff/60001/build/common.gypi#newco... build/common.gypi:2870: # This define is required to pull in the new Win8 interfaces from Presumably this comment needs to be updated to say "the new Win10 interfaces"? https://codereview.chromium.org/1378153003/diff/60001/build/vs_toolchain.py File build/vs_toolchain.py (right): https://codereview.chromium.org/1378153003/diff/60001/build/vs_toolchain.py#n... build/vs_toolchain.py:195: return ['9ff97c632ae1fee0c98bcd53e71770eb3a0d8deb'] If this hash is changed by the SDK then shouldn't the 2015 hash be changed also? https://codereview.chromium.org/1378153003/diff/60001/third_party/usrsctp/usr... File third_party/usrsctp/usrsctp.gyp (right): https://codereview.chromium.org/1378153003/diff/60001/third_party/usrsctp/usr... third_party/usrsctp/usrsctp.gyp:134: # this way would is incompatible with windows XP. "would is" -> "would be" - as long as your here.
Thanks https://codereview.chromium.org/1378153003/diff/60001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/1378153003/diff/60001/build/common.gypi#newco... build/common.gypi:2870: # This define is required to pull in the new Win8 interfaces from On 2015/10/05 20:30:11, brucedawson wrote: > Presumably this comment needs to be updated to say "the new Win10 interfaces"? Done. (probably should just delete that comment, but anyway...) https://codereview.chromium.org/1378153003/diff/60001/build/vs_toolchain.py File build/vs_toolchain.py (right): https://codereview.chromium.org/1378153003/diff/60001/build/vs_toolchain.py#n... build/vs_toolchain.py:195: return ['9ff97c632ae1fee0c98bcd53e71770eb3a0d8deb'] On 2015/10/05 20:30:11, brucedawson wrote: > If this hash is changed by the SDK then shouldn't the 2015 hash be changed also? I haven't packaged 2015, that's a whole separate ball of crazy yarn. https://codereview.chromium.org/1378153003/diff/60001/third_party/usrsctp/usr... File third_party/usrsctp/usrsctp.gyp (right): https://codereview.chromium.org/1378153003/diff/60001/third_party/usrsctp/usr... third_party/usrsctp/usrsctp.gyp:134: # this way would is incompatible with windows XP. On 2015/10/05 20:30:11, brucedawson wrote: > "would is" -> "would be" - as long as your here. Done.
> > "would is" -> "would be" - as long as your here. > > Done. You missed your chance to suggest that I should fix "your here" to "you're here" in my comment.
lgtm
On 2015/10/05 20:50:30, brucedawson wrote: > > > "would is" -> "would be" - as long as your here. > > > > Done. > > You missed your chance to suggest that I should fix "your here" to "you're here" > in my comment. I considered that for longer than the rest of the fixes in the CL! ;)
scottmg@chromium.org changed reviewers: + sky@chromium.org
+sky for chrome\browser\ui\views\tabs\window_finder_win.cc
CC +those with NaCl/PNaCl changes in the roll in case there's any reason not to roll to head.
(oops, autocomplete fail on mcgrathr)
LGTM
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378153003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378153003/120001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
NaCl inline asm fix landed, trying again.
The CQ bit was checked by scottmg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from brucedawson@chromium.org Link to the patchset: https://codereview.chromium.org/1378153003/#ps120001 (title: "include nacl roll")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378153003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378153003/120001
On 2015/10/06 19:08:29, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1378153003/120001 > View timeline at > https://chromium-cq-status.appspot.com/patch-timeline/1378153003/120001 I recommend using this syntax to list the changes present in a DEPS roll: https://chromium.googlesource.com/native_client/src/native_client/+log/719fce... It is a disadvantage that the changes aren't visible in the description, but the significant advantage is that the changes are more easily explorable. It's also more compact.
On 2015/10/06 19:33:26, brucedawson wrote: > On 2015/10/06 19:08:29, commit-bot: I haz the power wrote: > > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/patch-status/1378153003/120001 > > View timeline at > > https://chromium-cq-status.appspot.com/patch-timeline/1378153003/120001 > > I recommend using this syntax to list the changes present in a DEPS roll: > > https://chromium.googlesource.com/native_client/src/native_client/+log/719fce... > > It is a disadvantage that the changes aren't visible in the description, but the > significant advantage is that the changes are more easily explorable. It's also > more compact. Added that to the description, but I like having the titles inline too.
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Belt and suspenders, 'cause why not. You can also use --oneline instead of --pretty=oneline, which adds --abbrev-commit which shortens the hashes. Personal taste I'm sure, but I like the compact form.
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/3f6f89251dc210b24a36398237d374a87d4a3b33 Cr-Commit-Position: refs/heads/master@{#352667}
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/1390923002/ by scottmg@chromium.org. The reason for reverting is: Suspected of causing compile timeouts on Win builders. e.g. http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/14141 OTOH, all trybots were fine, I can't repro in a VM, and some of the compiles on waterfall are fine. So... needs some investigation..
Message was sent while issue was closed.
Description was changed from ========== win: Update to Win 10 SDK Tested on clean Win7 VM against both VS2013 and clang=1 at 247874-1. NaCl roll has to be included here because clang-cl warns if _WIN32_WINNT differs when building NaCl in Chrome. Roll includes: https://chromium.googlesource.com/native_client/src/native_client/+log/719fce... d:\src\cr3\src>git log 719fce7fa0c1f11cf05d5c20cdfa6648e8a35611..9c69f1fcb35b34f136da7ea7c91ceb743b9d2aaa --pretty=oneline 9c69f1fcb35b34f136da7ea7c91ceb743b9d2aaa win: Update to Windows 10 SDK bc87a5bbc9664e22fcfe01786d501d70f198b22f Update revision for PNaCl 8d12493d902fec4c91dc949ab3a553c680b354a5 Use -fgnu-inline-asm for non-SFI IRT GYP build a27e828a3f1408197fbe39a5649e0b12f5b83e5d PNaCl: Update llvm and subzero revision in pnacl/COMPONENT_REVISIONS 11234b3082981faaf98b3045b907e19dd15b2737 Make ncval_annotate accept command-line options for paths. 0825b8b3e036f434375963458f090287e98be57f Fix failure of NaClHostDirOpen("/") on windows b73b0a27a2f833e7937c69dcbceda60cf522cd24 Add a test for x86-32 IRT stack realignment 67569a6bf3dfbdc8392e3aed95fcab4a3b49865b Add --finalize option to pnacl-ld 89c677938dec5ee5460c40731f5a4028c5c39527 Build non-SFI version of sandboxed binaries 9906fe25373ca728aed81a6a3e944a42c0603298 Remove per-file *.gn from OWNERS 564d7b6489425339c1a4d667874f51a3ce3d8b0f Add x86 and x64 into the list of supported PNaCl architectures ea4179990a6d0a3570ca53fcd6d898df6ef0a408 PNaCl: Remove the -allow-asm option 8a68b7b483492ebd918b7cbd315a3b7738b2efee PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS 04d56826368fc7fcd5a802c1e3794c1abb4b3978 Build support for fnl. dafabd1973dad64651ab2ed93fabec9415843ff4 GN: Conditionalize x86-specific validator bits 9f06ea989d1257827a402be1b45cd0450296959a [Docs] Add wiki content to Markdown docs 644c971c7e492740d0fe0f997b9f5b01a23727fc PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS 13f84b78ff6a702434b1501fc06643a4c1721998 debug_stub: Avoid unused const warning on non-x86 builds R=brucedawson@chromium.org BUG=491424 Committed: https://crrev.com/3f6f89251dc210b24a36398237d374a87d4a3b33 Cr-Commit-Position: refs/heads/master@{#352667} ========== to ========== win: Update to Win 10 SDK Tested on clean Win7 VM against both VS2013 and clang=1 at 247874-1. R=brucedawson@chromium.org BUG=491424 Committed: https://crrev.com/3f6f89251dc210b24a36398237d374a87d4a3b33 Cr-Commit-Position: refs/heads/master@{#352667} ==========
Message was sent while issue was closed.
Waterfall bots are updated to post-Vista so trying again. 2015 isn't re-packaged with 10 SDK yet, so you'll have to use DEPOT_TOOLS_WIN_TOOLCHAIN=0 with a system install for now. Hopefully Update 1 RTM will be out soon anyway and we can package that.
The CQ bit was checked by scottmg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org, brucedawson@chromium.org Link to the patchset: https://codereview.chromium.org/1378153003/#ps140001 (title: "rebase for reland")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378153003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378153003/140001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378153003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378153003/140001
Message was sent while issue was closed.
Committed patchset #8 (id:140001)
Message was sent while issue was closed.
Patchset 8 (id:??) landed as https://crrev.com/1feffb4b7b1c2bfaf112a8993ae7ab0c16a52da9 Cr-Commit-Position: refs/heads/master@{#356373}
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:140001) has been created in https://codereview.chromium.org/1410153007/ by caseq@chromium.org. The reason for reverting is: This is a suspect in breaking Win bots (e.g. here http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/b...).
Message was sent while issue was closed.
Description was changed from ========== win: Update to Win 10 SDK Tested on clean Win7 VM against both VS2013 and clang=1 at 247874-1. R=brucedawson@chromium.org BUG=491424 Committed: https://crrev.com/3f6f89251dc210b24a36398237d374a87d4a3b33 Cr-Commit-Position: refs/heads/master@{#352667} Committed: https://crrev.com/1feffb4b7b1c2bfaf112a8993ae7ab0c16a52da9 Cr-Commit-Position: refs/heads/master@{#356373} ========== to ========== win: Update to Win 10 SDK Tested on clean Win7 VM against both VS2013 and clang=1 at 247874-1. R=brucedawson@chromium.org BUG=491424 Committed: https://crrev.com/3f6f89251dc210b24a36398237d374a87d4a3b33 Cr-Commit-Position: refs/heads/master@{#352667} Committed: https://crrev.com/1feffb4b7b1c2bfaf112a8993ae7ab0c16a52da9 Cr-Commit-Position: refs/heads/master@{#356373} ========== |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
