Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
5 years, 2 months ago by Michael Achenbach Modified:
5 years, 2 months ago Reviewers:
jochen (gone - plz use gerrit), M-A Ruel, tandrii(chromium) CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[swarming] Add isolate driver.
This is a simplified version of chromium's isolate driver:
- 'prepare' will create a *.isolate.gen.json with the
arguments to be used later.
- other modes will just be passed through to the isolate
script.
BUG=chromium:535160
LOG=n
NOTRY=true
Committed: https://crrev.com/983747acced0c6e97db3264ff6eaa8798f252231
Cr-Commit-Position: refs/heads/master@{#31046}
Patch Set 1 #
Total comments: 1
Patch Set 2 : presubmit #
Total comments: 10
Patch Set 3 : Review #
Created: 5 years, 2 months ago
Messages
Total messages: 17 (7 generated)
machenbach@chromium.org changed reviewers: + jochen@chromium.org, maruel@chromium.org, tandrii@chromium.org
PTAL. I brought back a simplified version of the driver without the wrapper in order to use the 'prepare' mode. This should make it easier to share infrastructure in the subsequent 'isolate tests' step. https://codereview.chromium.org/1378133005/diff/1/tools/isolate_driver.py File tools/isolate_driver.py (right): https://codereview.chromium.org/1378133005/diff/1/tools/isolate_driver.py#new... tools/isolate_driver.py:1: #!/usr/bin/env python 1:1 c/p from https://code.google.com/p/chromium/codesearch#chromium/src/tools/isolate_driv... with the wrapper cut out.
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378133005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378133005/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6254)
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378133005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378133005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/1378133005/diff/20001/tools/isolate_driver.py File tools/isolate_driver.py (right): https://codereview.chromium.org/1378133005/diff/20001/tools/isolate_driver.py... tools/isolate_driver.py:19: SWARMING_CLIENT_DIR = os.path.join(TOOLS_DIR, 'swarming_client') Remove lines 19-22 https://codereview.chromium.org/1378133005/diff/20001/tools/isolate_driver.py... tools/isolate_driver.py:40: args = sys.argv[1:] replace lines 40-41 with: if len(sys.argv) < 2: print >> sys.stderr, 'Internal failure; mode required' return 1 mode = sys.argv.args[1] args = sys.argv[1:] https://codereview.chromium.org/1378133005/diff/20001/tools/isolate_driver.py... tools/isolate_driver.py:49: if isolate is None or isolated is None or not mode: if not isolate or not isolated: https://codereview.chromium.org/1378133005/diff/20001/tools/isolate_driver.py... tools/isolate_driver.py:59: swarming_client = os.path.join(SRC_DIR, 'tools', 'swarming_client') os.path.join(TOOLS_DIR, 'swarming_client') https://codereview.chromium.org/1378133005/diff/20001/tools/isolate_driver.py... tools/isolate_driver.py:61: result = subprocess.call( return subprocess.call(
https://codereview.chromium.org/1378133005/diff/20001/tools/isolate_driver.py File tools/isolate_driver.py (right): https://codereview.chromium.org/1378133005/diff/20001/tools/isolate_driver.py... tools/isolate_driver.py:19: SWARMING_CLIENT_DIR = os.path.join(TOOLS_DIR, 'swarming_client') On 2015/10/01 12:17:06, M-A Ruel wrote: > Remove lines 19-22 Done. https://codereview.chromium.org/1378133005/diff/20001/tools/isolate_driver.py... tools/isolate_driver.py:40: args = sys.argv[1:] On 2015/10/01 12:17:06, M-A Ruel wrote: > replace lines 40-41 with: > if len(sys.argv) < 2: > print >> sys.stderr, 'Internal failure; mode required' > return 1 > mode = sys.argv.args[1] > args = sys.argv[1:] Done. https://codereview.chromium.org/1378133005/diff/20001/tools/isolate_driver.py... tools/isolate_driver.py:49: if isolate is None or isolated is None or not mode: On 2015/10/01 12:17:06, M-A Ruel wrote: > if not isolate or not isolated: Done. https://codereview.chromium.org/1378133005/diff/20001/tools/isolate_driver.py... tools/isolate_driver.py:59: swarming_client = os.path.join(SRC_DIR, 'tools', 'swarming_client') On 2015/10/01 12:17:06, M-A Ruel wrote: > os.path.join(TOOLS_DIR, 'swarming_client') Done. https://codereview.chromium.org/1378133005/diff/20001/tools/isolate_driver.py... tools/isolate_driver.py:61: result = subprocess.call( On 2015/10/01 12:17:06, M-A Ruel wrote: > return subprocess.call( Done.
The CQ bit was checked by machenbach@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org Link to the patchset: https://codereview.chromium.org/1378133005/#ps30001 (title: "Review")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378133005/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378133005/30001
Message was sent while issue was closed.
Committed patchset #3 (id:30001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/983747acced0c6e97db3264ff6eaa8798f252231 Cr-Commit-Position: refs/heads/master@{#31046} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
