Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1378073003: Move build instructions to README.md (Closed)

Created:
5 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez, Bons
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move build instructions to README.md That way, they'll be automatically displayed on gitiles BUG= R=andybons@chromium.org, tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/16703313a78f2370726a0663e9b90d67610daad8

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -82 lines) Patch
D README View 1 chunk +0 lines, -1 line 0 comments Download
A + README.md View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D docs/build.md View 1 1 chunk +0 lines, -82 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
jochen (gone - plz use gerrit)
5 years, 2 months ago (2015-09-30 07:53:56 UTC) #1
Tom Sepez
On 2015/09/30 07:53:56, jochen wrote: Thought this was done in https://codereview.chromium.org/1356323002/
5 years, 2 months ago (2015-09-30 19:16:58 UTC) #2
jochen (gone - plz use gerrit)
hum. I guess we should at least update the README then to point to the ...
5 years, 2 months ago (2015-09-30 21:07:25 UTC) #4
Tom Sepez
On 2015/09/30 21:07:25, jochen wrote: > hum. I guess we should at least update the ...
5 years, 2 months ago (2015-10-01 16:08:03 UTC) #5
jochen (gone - plz use gerrit)
done
5 years, 2 months ago (2015-10-02 07:59:38 UTC) #6
Tom Sepez
lgtm
5 years, 2 months ago (2015-10-02 16:33:16 UTC) #7
Bons
lgtm
5 years, 2 months ago (2015-10-05 17:52:25 UTC) #8
jochen (gone - plz use gerrit)
5 years, 2 months ago (2015-10-07 09:21:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
16703313a78f2370726a0663e9b90d67610daad8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698