cros: Update SAML flow.

cros: Update SAML flow.

- Update password confirm UI per mock;
- Show password confirm UI with an error message after 1st failed attempt;
- Rename message box screen to fatal error screen;
- Show fatal error screen on 2nd failed attempt;

BUG=330206
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248893

[xiyuan, 2014-01-31 21:39:23]

PTAL. Will update screenshots to bug.

[xiyuan, 2014-02-04 15:59:34]

nkostylev, could you help to review the CL? Thanks.

[bartfab (slow), 2014-02-04 20:10:47]

lgtm

https://codereview.chromium.org/137803008/diff/140001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/137803008/diff/140001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:1321: <message
name="IDS_LOGIN_CONFIRM_PASSWORD_ERROR_TEXT" desc="Error text to show when the
user typed password could not be verified.">
Nit: s/user typed/user-typed/ (or "password typed by the user")

https://codereview.chromium.org/137803008/diff/140001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/screen_confirm_password.css
(right):

https://codereview.chromium.org/137803008/diff/140001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_confirm_password.css:1: /*
Copyright 2013 The Chromium Authors. All rights reserved.
Nit: A lot of this file looks like it was copy & pasted from some other GAIA CSS
file. Would it be possible to share a CSS file for the common styles?

[xiyuan, 2014-02-04 21:23:10]

https://codereview.chromium.org/137803008/diff/140001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/137803008/diff/140001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:1321: <message
name="IDS_LOGIN_CONFIRM_PASSWORD_ERROR_TEXT" desc="Error text to show when the
user typed password could not be verified.">
On 2014/02/04 20:10:47, bartfab wrote:
> Nit: s/user typed/user-typed/ (or "password typed by the user")

Done. Changed to "password typed by the user".

https://codereview.chromium.org/137803008/diff/140001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/screen_confirm_password.css
(right):

https://codereview.chromium.org/137803008/diff/140001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_confirm_password.css:1: /*
Copyright 2013 The Chromium Authors. All rights reserved.
On 2014/02/04 20:10:47, bartfab wrote:
> Nit: A lot of this file looks like it was copy & pasted from some other GAIA
CSS
> file. Would it be possible to share a CSS file for the common styles?

The password field and the blue button could be put into a css file that can be
shared. Split them into a gaia.css.

The other place uses the Gaia CSS is the offline page of gaia_auth extension
which does not have access chrome://resources etc and cannot directly do
<include>. It is a bit hard to share the style with it. I'll just leave it like
this and we can revisit when there are more places needs gaia style.

[xiyuan, 2014-02-05 01:19:43]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2014-02-05 03:48:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/137803008/300001

[commit-bot: I haz the power, 2014-02-05 07:10:20]

Change committed as 248893

[Nikita (slow), 2014-02-06 05:08:25]

lgtm

https://codereview.chromium.org/137803008/diff/300001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/screen_confirm_password.css
(right):

https://codereview.chromium.org/137803008/diff/300001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_confirm_password.css:50: <include
src="gaia.css">
Who else includes this CSS?

https://codereview.chromium.org/137803008/diff/300001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/screen_fatal_error.js (right):

https://codereview.chromium.org/137803008/diff/300001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_fatal_error.js:50:
Oobe.getInstance().headerHidden = true;
nit: When does this header will be restored if we return back to the user pods?

https://code.google.com/p/chromium/codesearch#search/&q=Oobe.getInstance%5C(%...

[xiyuan, 2014-02-06 05:46:04]

https://codereview.chromium.org/137803008/diff/300001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/screen_confirm_password.css
(right):

https://codereview.chromium.org/137803008/diff/300001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_confirm_password.css:50: <include
src="gaia.css">
On 2014/02/06 05:08:25, Nikita Kostylev wrote:
> Who else includes this CSS?

This is the only webui uses it right now. Put it in a separate CSS to make it
easier to share it. This CSS is a subset of offline.css (from real gaia). I have
not find a good way share them.

https://codereview.chromium.org/137803008/diff/300001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/screen_fatal_error.js (right):

https://codereview.chromium.org/137803008/diff/300001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_fatal_error.js:50:
Oobe.getInstance().headerHidden = true;
On 2014/02/06 05:08:25, Nikita Kostylev wrote:
> nit: When does this header will be restored if we return back to the user
pods?
> 

Right now it is okay because we always go back to Gaia after this error and Gaia
shows header. But you are right, we probably should restore this in onDismiss in
case the callback is changed in the future. I will do that in a follow up CL.