Issue 137803004: Update heap/ classes to use OVERRIDE / FINAL when needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137803004: Update heap/ classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive

Modified:
6 years, 11 months ago

Reviewers:
haraken, Mads Ager (chromium)

CC:
blink-reviews, Mads Ager (chromium)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Update heap/ classes to use OVERRIDE / FINAL when needed Update heap/ classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. These were found using the chromium style clang plugin. R=haraken BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165047

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -22 lines)			Patch
M	Source/heap/Handle.h	View	1 chunk	+1 line, -1 line	1 comment	Download
M	Source/heap/Heap.cpp	View	2 chunks	+17 lines, -17 lines	0 comments	Download
M	Source/heap/HeapTest.cpp	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/137803004/1

6 years, 11 months ago (2014-01-14 07:22:28 UTC) #3

Mads Ager (chromium)

LGTM https://codereview.chromium.org/137803004/diff/1/Source/heap/Handle.h File Source/heap/Handle.h (right): https://codereview.chromium.org/137803004/diff/1/Source/heap/Handle.h#newcode75 Source/heap/Handle.h:75: ~PersistentBase() Don't you want virtual here as well?

6 years, 11 months ago (2014-01-14 07:26:42 UTC) #4

Message was sent while issue was closed.

Change committed as 165047

Expand Messages | Collapse Messages