Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1378023004:
Refugee from Dead Machine 2: Have GrRectBlurEffect use Linear filtering (rather than Nearest
|
Created:
5 years, 2 months ago by robertphillips Modified:
4 years, 7 months ago Reviewers:
bsalomon CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionHave GrRectBlurEffect use Linear filtering (rather than Nearest Neighbor)
Committed: https://skia.googlesource.com/skia/+/2d70bcccc9ba8f3898a7ae506ba7410ed8e9c9db
Committed: https://skia.googlesource.com/skia/+/5175b9563055926b4969d57f06e4ae49b86e055b
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1378023004
Patch Set 1 #Patch Set 2 : Updated #Patch Set 3 : update to ToT #Messages
Total messages: 21 (10 generated)
robertphillips@google.com changed reviewers: + bsalomon@google.com
The CQ bit was checked by bsalomon@google.com
lgtm
The CQ bit was unchecked by bsalomon@google.com
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378023004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378023004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378023004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378023004/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/2d70bcccc9ba8f3898a7ae506ba7410ed8e9c9db
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1378323002/ by robertphillips@google.com. The reason for reverting is: Failing some Blink layout tests - will wait until after branch..
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com Link to the patchset: https://codereview.chromium.org/1378023004/#ps20001 (title: "Updated")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378023004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378023004/20001
Re-landing to assess Blink layout test situation - will revert.
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/5175b9563055926b4969d57f06e4ae49b86e055b
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1378813004/ by robertphillips@google.com. The reason for reverting is: Trial run confirmed layout test expectations - will reland after suppressions.
Description was changed from ========== Have GrRectBlurEffect use Linear filtering (rather than Nearest Neighbor) Committed: https://skia.googlesource.com/skia/+/2d70bcccc9ba8f3898a7ae506ba7410ed8e9c9db Committed: https://skia.googlesource.com/skia/+/5175b9563055926b4969d57f06e4ae49b86e055b ========== to ========== Have GrRectBlurEffect use Linear filtering (rather than Nearest Neighbor) Committed: https://skia.googlesource.com/skia/+/2d70bcccc9ba8f3898a7ae506ba7410ed8e9c9db Committed: https://skia.googlesource.com/skia/+/5175b9563055926b4969d57f06e4ae49b86e055b GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Have GrRectBlurEffect use Linear filtering (rather than Nearest Neighbor) Committed: https://skia.googlesource.com/skia/+/2d70bcccc9ba8f3898a7ae506ba7410ed8e9c9db Committed: https://skia.googlesource.com/skia/+/5175b9563055926b4969d57f06e4ae49b86e055b GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Have GrRectBlurEffect use Linear filtering (rather than Nearest Neighbor) Committed: https://skia.googlesource.com/skia/+/2d70bcccc9ba8f3898a7ae506ba7410ed8e9c9db Committed: https://skia.googlesource.com/skia/+/5175b9563055926b4969d57f06e4ae49b86e055b GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== |
