Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Unified Diff: chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc

Issue 1378023003: Update Location Bar Bubbles Layout for Material Design (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated Font Color Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
diff --git a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
index ed09f59f1616ebb12ab6dd6e5a0d9b8c75f9f557..4364bad16ed4cb6980d62226afa3cdc3995db2e2 100644
--- a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
+++ b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
@@ -6,6 +6,7 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/ui/views/layout_constants.h"
+#include "ui/base/resource/material_design/material_design_controller.h"
Peter Kasting 2015/10/05 21:53:13 Nit: This is no longer needed
jonross 2015/10/06 18:00:13 Done.
#include "ui/base/resource/resource_bundle.h"
#include "ui/gfx/canvas.h"
#include "ui/gfx/color_utils.h"
@@ -45,7 +46,6 @@ IconLabelBubbleView::IconLabelBubbleView(int contained_image,
// |image_| as a separate mouse hover region from |this|.
image_->set_interactive(false);
AddChildView(image_);
-
Peter Kasting 2015/10/05 21:53:13 Nit: Don't remove this
jonross 2015/10/06 18:00:13 Done.
label_->SetEnabledColor(text_color);
if (elide_in_middle)
@@ -105,7 +105,7 @@ void IconLabelBubbleView::Layout() {
GetBubbleOuterPadding(!is_extension_icon_)),
0, image_->GetPreferredSize().width(), height());
- const int padding = GetLayoutConstant(LOCATION_BAR_HORIZONTAL_PADDING);
+ const int padding = GetLayoutConstant(ICON_LABEL_VIEW_INTERNAL_PADDING);
int pre_label_width =
GetBubbleOuterPadding(true) + (image_width ? (image_width + padding) : 0);
label_->SetBounds(pre_label_width, 0,
@@ -117,7 +117,7 @@ gfx::Size IconLabelBubbleView::GetSizeForLabelWidth(int width) const {
gfx::Size size(image_->GetPreferredSize());
if (ShouldShowBackground()) {
const int image_width = image_->GetPreferredSize().width();
- const int padding = GetLayoutConstant(LOCATION_BAR_HORIZONTAL_PADDING);
+ const int padding = GetLayoutConstant(ICON_LABEL_VIEW_INTERNAL_PADDING);
const int non_label_width =
GetBubbleOuterPadding(true) +
(image_width ? (image_width + padding) : 0) +

Powered by Google App Engine
This is Rietveld 408576698