Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1377973007: Update catapult recipe to run py-vulcanize (tvcm) tests. (Closed)

Created:
5 years, 2 months ago by qyearsley
Modified:
5 years, 2 months ago
Reviewers:
sullivan
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M scripts/slave/recipes/catapult.py View 2 chunks +6 lines, -1 line 0 comments Download
M scripts/slave/recipes/catapult.expected/basic.json View 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
qyearsley
Note: This is dependent on https://codereview.chromium.org/1376953005/.
5 years, 2 months ago (2015-10-06 18:39:54 UTC) #2
sullivan
lgtm
5 years, 2 months ago (2015-10-06 18:59:18 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377973007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377973007/1
5 years, 2 months ago (2015-10-08 22:50:09 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-08 22:52:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377973007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377973007/1
5 years, 2 months ago (2015-10-08 22:53:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=297072
5 years, 2 months ago (2015-10-08 22:56:37 UTC) #10
qyearsley
5 years, 2 months ago (2015-10-09 20:30:30 UTC) #11
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1400913002/ by qyearsley@chromium.org.

The reason for reverting is: Causes failures on catapult waterfall and
tryserver:
https://build.chromium.org/p/tryserver.client.catapult/builders
https://build.chromium.org/p/client.catapult/builders.

Powered by Google App Engine
This is Rietveld 408576698