third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp - Issue 1377963004: Use FrameSelection::selectedText where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

Issue 1377963004: Use FrameSelection::selectedText where possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update layout in HTMLTextFormControlElement::setSelectionRange. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

index b3421b15e87f3c948e148727b9f18a554e1b5353..45d2682c14e708ffda352c0e0dfa5e971028ad78 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

@@ -354,6 +354,8 @@ void HTMLTextFormControlElement::setSelectionRange(int start, int end, TextField

if (openShadowRoot() || !isTextFormControl() || !inDocument())

return;

+ document().updateLayoutIgnorePendingStylesheets();

tkent 2015/10/20 23:11:32 nit: Add a comment why we need to update layout.

const int editorValueLength = static_cast<int>(innerEditorValue().length());

ASSERT(editorValueLength >= 0);

end = std::max(std::min(end, editorValueLength), 0);