Use FrameSelection::selectedText where possible.

third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
index a44fb7fe158a41f6cea467fb506ce0c457227f9c..5e33c70f0e8b531f4afe6e591f24f53cbf0b8996 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
@@ -269,7 +269,8 @@ EphemeralRange VisibleSelection::toNormalizedEphemeralRange() const
     //                       ^ selected
     //
     ASSERT(isRange());
-    return normalizeRange(EphemeralRange(m_start, m_end));
+    const EphemeralRange range(m_start, m_end);
+    return range.isNotNull() ? normalizeRange(range) : range;

[yosin_UTC9, 2015/10/01 06:29:09]

Why do you check |range.isNotNull()|?
If |isRange()| is true, |range| can't be null.

[kotenkov, 2015/10/02 08:28:07]

Yes, you are right. Now I understand that I should check for |isRange()| in
|extractSelectedTextAlgorithm()| and |extractSelectedHTMLAlgorithm()|. As I did
not check it in the first patchset, I had to check for |isNotNull()| here. That
was clearly a mistake.

 }
 
 bool VisibleSelection::expandUsingGranularity(TextGranularity granularity)
@@ -1172,7 +1173,8 @@ VisibleSelectionTemplate<Strategy>::VisibleSelectionTemplate()
 template <typename Strategy>
 EphemeralRangeTemplate<Strategy> VisibleSelectionTemplate<Strategy>::toNormalizedEphemeralRange() const
 {
-    return normalizeRange(EphemeralRangeTemplate<Strategy>(start(), end()));
+    const EphemeralRangeTemplate<Strategy> range(start(), end());

[yosin_UTC9, 2015/10/01 06:29:09]

Do you have a case we call |toNormalizedEphemeralRange()| with empty selection?

If we have a such case, let's make |normalizeRange()| to handle null
case rather than each call site.

[kotenkov, 2015/10/02 08:28:07]

No, it seems, that we should only call |toNormalizedEphemeralRange()| if
|isRange()| is true and in that case the range cannot be null.

+    return range.isNotNull() ? normalizeRange(range) : range;
 }
 
 template <typename Strategy>