snapshot/win/process_reader_win.cc - Issue 1377963002: win: Add and use a custom CaptureContext() implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/win/process_reader_win.cc

Issue 1377963002: win: Add and use a custom CaptureContext() implementation (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Address review feeback (2) Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: snapshot/win/process_reader_win.cc

diff --git a/snapshot/win/process_reader_win.cc b/snapshot/win/process_reader_win.cc

index bcdf448326941f20a1f455cb087b429bf4eec04b..20e17ed93959463ddc50df960a8aedadbe8dd9fd 100644

--- a/snapshot/win/process_reader_win.cc

+++ b/snapshot/win/process_reader_win.cc

@@ -18,6 +18,7 @@

#include "base/memory/scoped_ptr.h"

#include "base/numerics/safe_conversions.h"

+#include "util/win/capture_context.h"

#include "util/win/nt_internals.h"

#include "util/win/ntstatus_logging.h"

#include "util/win/process_structs.h"

@@ -128,7 +129,7 @@ bool FillThreadContextAndSuspendCount(HANDLE thread_handle,

DCHECK(suspension_state == ProcessSuspensionState::kRunning);

thread->suspend_count = 0;

DCHECK(!is_64_reading_32);

- RtlCaptureContext(&thread->context.native);

+ CaptureContext(&thread->context.native);

} else {

DWORD previous_suspend_count = SuspendThread(thread_handle);

if (previous_suspend_count == -1) {

« no previous file with comments | « snapshot/win/exception_snapshot_win_test.cc ('k') | util/util.gyp » ('j') | no next file with comments »