third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp - Issue 1377943005: Change StyleBuilderConverter functions to take const CSSValue&s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 1377943005: Change StyleBuilderConverter functions to take const CSSValue&s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@style_map_references

Patch Set: Rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp ('k') | third_party/WebKit/Source/core/dom/TextLinkColors.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

index 5791ab77552596542580aca92ea96fa0e7d3683b..379d0c1ffb6bdab96204dc061f95fa7da48cf4a0 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

@@ -162,9 +162,9 @@ void StyleBuilderFunctions::applyValueCSSPropertyColor(StyleResolverState& state

}

if (state.applyPropertyToRegularStyle())

- state.style()->setColor(StyleBuilderConverter::convertColor(state, value));

+ state.style()->setColor(StyleBuilderConverter::convertColor(state, *value));

if (state.applyPropertyToVisitedLinkStyle())

- state.style()->setVisitedLinkColor(StyleBuilderConverter::convertColor(state, value, true));

+ state.style()->setVisitedLinkColor(StyleBuilderConverter::convertColor(state, *value, true));

}

void StyleBuilderFunctions::applyInitialCSSPropertyCursor(StyleResolverState& state)

@@ -212,7 +212,7 @@ void StyleBuilderFunctions::applyValueCSSPropertyGlyphOrientationVertical(StyleR

if (value->isPrimitiveValue() && toCSSPrimitiveValue(value)->getValueID() == CSSValueAuto)

state.style()->accessSVGStyle().setGlyphOrientationVertical(GO_AUTO);

else

- state.style()->accessSVGStyle().setGlyphOrientationVertical(StyleBuilderConverter::convertGlyphOrientation(state, value));

+ state.style()->accessSVGStyle().setGlyphOrientationVertical(StyleBuilderConverter::convertGlyphOrientation(state, *value));

}

void StyleBuilderFunctions::applyInitialCSSPropertyGridTemplateAreas(StyleResolverState& state)

@@ -839,7 +839,7 @@ void StyleBuilderFunctions::applyValueCSSPropertyBaselineShift(StyleResolverStat

CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);

if (!primitiveValue->isValueID()) {

svgStyle.setBaselineShift(BS_LENGTH);

- svgStyle.setBaselineShiftValue(StyleBuilderConverter::convertLength(state, primitiveValue));

+ svgStyle.setBaselineShiftValue(StyleBuilderConverter::convertLength(state, *primitiveValue));

return;

}

switch (primitiveValue->getValueID()) {