Issue 1377943002: Merge to M46: Fix blank page issue caused by too strict correction on bpc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1377943002: Merge to M46: Fix blank page issue caused by too strict correction on bpc (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@2490

Target Ref:
refs/heads/chromium/2490

Visibility:
Public.

More Reviews

Description

Merge to M46: Fix blank page issue caused by too strict correction on bpc For bit per component (bpc), PDF spec mentions that a RunLengthDecode or DCTDecode filter shall always deliver 8-bit samples. However, some PDF files don't follow this rule. We can find that filter is RunLengthDecode but bpc is 1 in the provided test file. In this case, pdfium will correct bpc to 8 but the actual bpc is 1. It causes a failure because the data is much more than the expected. To handle this case, pdfium doesn't correct bpc to 8 when the original bpc is 1. BUG=512557 R=tsepez@chromium.org TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1328213002 . (cherry picked from commit 3500e90e9e42fa84dd6f07da16cfcf197ec98283) Committed: https://pdfium.googlesource.com/pdfium/+/0b8f2fee646c53b3e6eb1fbbf13211f286e8cb82

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -2 lines)			Patch
M	core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp	View	1 chunk	+5 lines, -2 lines	0 comments	Download
A	testing/resources/pixel/bug_512557.in	View	Binary file		0 comments	Download
A	testing/resources/pixel/bug_512557_expected.pdf.0.png	View	Binary file		0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

5 years, 2 months ago (2015-09-29 19:26:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0b8f2fee646c53b3e6eb1fbbf13211f286e8cb82 (presubmit successful).

Expand Messages | Collapse Messages