Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Unified Diff: content/public/browser/content_browser_client.h

Issue 1377933004: Modify --isolate-extensions to not isolate hosted apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_isolate_apps3
Patch Set: Fixes from charlie Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/site_isolation_policy.cc ('k') | content/public/browser/content_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/content_browser_client.h
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index d01fe1524c813b3be08dc76910d50784093ee87d..9fe50dc86738cbcafda546a0814c12665fcc78e2 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -180,9 +180,22 @@ class CONTENT_EXPORT ContentBrowserClient {
virtual bool ShouldUseProcessPerSite(BrowserContext* browser_context,
const GURL& effective_url);
+ // Returns true if site isolation should be enabled for |effective_url|. This
+ // call allows the embedder to supplement the site isolation policy enforced
+ // by the content layer.
+ //
+ // Will only be called if both of the following happen:
+ // 1. The embedder asked to be consulted, by returning true from
+ // ContentClient::IsSupplementarySiteIsolationModeEnabled().
+ // 2. The content layer didn't decide to isolate |effective_url| according
+ // to its internal policy (e.g. because of --site-per-process).
+ virtual bool DoesSiteRequireDedicatedProcess(BrowserContext* browser_context,
+ const GURL& effective_url);
+
// Returns true unless the effective URL is part of a site that cannot live in
- // a process dedicated to that site. This is only called if
- // SiteIsolationPolicy::DoesSiteRequireDedicatedProcess returns true.
+ // a process restricted to just that site. This is only called if site
+ // isolation is enabled for this URL, and is a bug workaround.
+ //
// TODO(nick): Remove this function once https://crbug.com/160576 is fixed,
// and origin lock can be applied to all URLs.
virtual bool ShouldLockToOrigin(BrowserContext* browser_context,
« no previous file with comments | « content/common/site_isolation_policy.cc ('k') | content/public/browser/content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698