Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: chrome/browser/site_details_browsertest.cc

Issue 1377933004: Modify --isolate-extensions to not isolate hosted apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_isolate_apps3
Patch Set: One more comment fix. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/site_details_browsertest.cc
diff --git a/chrome/browser/site_details_browsertest.cc b/chrome/browser/site_details_browsertest.cc
index 43c955aa0f0f5007af8564410da1e946e5ba7c07..2754190e631104a044a3e57cab95856cc86cd4c5 100644
--- a/chrome/browser/site_details_browsertest.cc
+++ b/chrome/browser/site_details_browsertest.cc
@@ -746,14 +746,14 @@ IN_PROC_BROWSER_TEST_F(SiteDetailsBrowserTest, IsolateExtensionsHostedApps) {
ElementsAre(Bucket(1, 1)));
EXPECT_THAT(details->uma()->GetAllSamples(
"SiteIsolation.IsolateExtensionsProcessCountEstimate"),
- ElementsAre(Bucket(2, 1)));
+ ElementsAre(Bucket(1, 1)));
EXPECT_THAT(details->uma()->GetAllSamples(
"SiteIsolation.IsolateExtensionsProcessCountLowerBound"),
- ElementsAre(Bucket(2, 1)));
+ ElementsAre(Bucket(1, 1)));
EXPECT_THAT(details->uma()->GetAllSamples(
"SiteIsolation.IsolateExtensionsProcessCountNoLimit"),
- ElementsAre(Bucket(2, 1)));
- EXPECT_THAT(GetRenderProcessCount(), EqualsIfExtensionsIsolated(2));
+ ElementsAre(Bucket(1, 1)));
+ EXPECT_THAT(GetRenderProcessCount(), EqualsIfExtensionsIsolated(1));
ui_test_utils::NavigateToURL(browser(), app_in_web_iframe_url);
details = new TestMemoryDetails();
@@ -763,13 +763,13 @@ IN_PROC_BROWSER_TEST_F(SiteDetailsBrowserTest, IsolateExtensionsHostedApps) {
ElementsAre(Bucket(1, 1)));
EXPECT_THAT(details->uma()->GetAllSamples(
"SiteIsolation.IsolateExtensionsProcessCountEstimate"),
- ElementsAre(Bucket(2, 1)));
+ ElementsAre(Bucket(1, 1)));
EXPECT_THAT(details->uma()->GetAllSamples(
"SiteIsolation.IsolateExtensionsProcessCountLowerBound"),
- ElementsAre(Bucket(2, 1)));
+ ElementsAre(Bucket(1, 1)));
EXPECT_THAT(details->uma()->GetAllSamples(
"SiteIsolation.IsolateExtensionsProcessCountNoLimit"),
- ElementsAre(Bucket(2, 1)));
+ ElementsAre(Bucket(1, 1)));
- EXPECT_THAT(GetRenderProcessCount(), EqualsIfExtensionsIsolated(2));
+ EXPECT_THAT(GetRenderProcessCount(), EqualsIfExtensionsIsolated(1));
}

Powered by Google App Engine
This is Rietveld 408576698