chrome/test/data/extensions/api_test/runtime/uninstall_url/test.js - Issue 137793011: Require user confirmation for chrome.management.uninstall except when uninstalling self.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/runtime/uninstall_url/test.js

Issue 137793011: Require user confirmation for chrome.management.uninstall except when uninstalling self. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix ExtensionManagementApiBrowserTest.LaunchApp Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/management/test/uninstall.js ('k') | chrome/test/data/extensions/api_test/webstore_private/common.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/runtime/uninstall_url/test.js

diff --git a/chrome/test/data/extensions/api_test/runtime/uninstall_url/test.js b/chrome/test/data/extensions/api_test/runtime/uninstall_url/test.js

index 8cf2fc3b67965bc46eca042944b8911ff4dbbe79..5d42e56f4e14c739ed9649fc5320fee0779e5900 100644

--- a/chrome/test/data/extensions/api_test/runtime/uninstall_url/test.js

+++ b/chrome/test/data/extensions/api_test/runtime/uninstall_url/test.js

@@ -12,13 +12,14 @@ var uninstalled = false;

chrome.test.runTests([

function uninstallURL() {

chrome.management.getAll(function(results) {

- for(var i = 0;i<results.length;i++)

- {

+ for(var i = 0; i < results.length; i++) {

if (results[i].name == sets_uninstall_url) {

- chrome.management.uninstall(results[i].id, pass(function() {

- chrome.tabs.query({'url': uninstall_url}, pass(function(tabs) {

- chrome.test.assertEq(tabs.length, 1);

- chrome.test.assertEq(tabs[0].url, uninstall_url);

+ chrome.test.runWithUserGesture(pass(function() {

+ chrome.management.uninstall(results[i].id, pass(function() {

+ chrome.tabs.query({'url': uninstall_url}, pass(function(tabs) {

+ chrome.test.assertEq(tabs.length, 1);

+ chrome.test.assertEq(tabs[0].url, uninstall_url);

+ }));

}));

uninstalled = true;