chrome/test/data/extensions/api_test/webstore_private/common.js - Issue 137793011: Require user confirmation for chrome.management.uninstall except when uninstalling self.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/webstore_private/common.js

Issue 137793011: Require user confirmation for chrome.management.uninstall except when uninstalling self. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix ExtensionWebstorePrivateApiTest.* and ExtensionManagementTest.ExternalPolicyRefresh Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/runtime/uninstall_url/test.js ('K') | « chrome/test/data/extensions/api_test/runtime/uninstall_url/test.js ('k') | chrome/test/data/extensions/management/uninstall_extension/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/webstore_private/common.js

diff --git a/chrome/test/data/extensions/api_test/webstore_private/common.js b/chrome/test/data/extensions/api_test/webstore_private/common.js

index 1021877fc0b07b00dca55cc80524ef1d4da4e2f3..cf1ed3d6ca11c3f39eeed11f975bf82fa820ede6 100644

--- a/chrome/test/data/extensions/api_test/webstore_private/common.js

+++ b/chrome/test/data/extensions/api_test/webstore_private/common.js

@@ -90,7 +90,9 @@ function installAndCleanUp(installOptions, whileInstalled) {

whileInstalled();

- chrome.management.uninstall(extensionId, {}, callbackPass());

+ chrome.test.runWithUserGesture(function() {

not at google - send to devlin 2014/01/16 05:07:39 also need a callbackPass around this one

meacer 2014/01/16 18:59:40 Done.

+ chrome.management.uninstall(extensionId, {}, callbackPass());

+ });

}));

}