chrome/test/data/extensions/api_test/management/test/uninstall.js - Issue 137793011: Require user confirmation for chrome.management.uninstall except when uninstalling self.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/management/test/uninstall.js

Issue 137793011: Require user confirmation for chrome.management.uninstall except when uninstalling self. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/management/management_policy/prohibited.js ('K') | « chrome/test/data/extensions/api_test/management/management_policy/prohibited.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/management/test/uninstall.js

diff --git a/chrome/test/data/extensions/api_test/management/test/uninstall.js b/chrome/test/data/extensions/api_test/management/test/uninstall.js

index 252291dbef64ace5f779faf2fee52965e78f4d4c..6bba715b79024b6cf35331a741ecff99a5f75d49 100644

--- a/chrome/test/data/extensions/api_test/management/test/uninstall.js

+++ b/chrome/test/data/extensions/api_test/management/test/uninstall.js

@@ -11,14 +11,16 @@ function uninstall(name) {

var old_count = items.length;

var item = getItemNamed(items, name);

expected_id = item.id;

- chrome.management.uninstall(item.id, callback(function() {

- chrome.management.getAll(callback(function(items2) {

- assertEq(old_count - 1, items2.length);

- for (var i = 0; i < items2.length; i++) {

- assertFalse(items2[i].name == name);

- }

+ chrome.test.runWithUserGesture(function() {

+ chrome.management.uninstall(item.id, callback(function() {

+ chrome.management.getAll(callback(function(items2) {

+ assertEq(old_count - 1, items2.length);

+ for (var i = 0; i < items2.length; i++) {

+ assertFalse(items2[i].name == name);

+ }

+ }));

}));

- }));

+ });

}));

}