Require user confirmation for chrome.management.uninstall except when uninstalling self.

chrome/test/data/extensions/api_test/management/management_policy/prohibited.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var callback = chrome.test.callback;
 
 // The names of the extensions to operate on, from their manifest.json files.
 var ENABLED_NAME = 'enabled_extension';
 var DISABLED_NAME = 'disabled_extension';
 var UNINSTALL_NAME = 'enabled_extension';
 
-var EXPECTED_ERROR = 'Extension * cannot be modified by user';
+var EXPECTED_ERROR = 'Extension * cannot be modified by user.';
 
 // Given a list of extension items, finds the one with the given name.
 function findByName(items, name) {
   var item;
   for (var i = 0; i < items.length; i++) {
     item = items[i];
     if (item.name == name)
       break;
   }
   if (name != item.name)
@@ skipping 39 matching lines @@
   },
 
   // Tests uninstalling an extension, expecting it to fail.
   function prohibitedUninstall() {
     chrome.management.getAll(callback(function(items) {
       var item = findByName(items, UNINSTALL_NAME);
       chrome.test.assertEq(false, item.mayDisable);
 
       var id = item.id;
       var expectedError = EXPECTED_ERROR.replace('*', id);
-      chrome.management.uninstall(id,
-          callback(function() { checkEnabled(id, true); }, expectedError));
+      chrome.test.runWithUserGesture(function() {
+        chrome.management.uninstall(id,
+            callback(function() { checkEnabled(id, true); }, expectedError));
+      });

[not at google - send to devlin, 2014/01/16 01:13:41]

(making this comment in an arbitrary place)

can we add a test somewhere that calls chrome.management.uninstall without a
user gesture and makes sure it fails?

[meacer, 2014/01/16 01:59:19]

Added uninstallEnabledAppWithoutUserGesture to management/test/uninstall.js

     }));
   }
 ];
 
 chrome.test.runTests(tests);