Require user confirmation for chrome.management.uninstall except when uninstalling self.

chrome/browser/extensions/api/management/management_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/management/management_api.h"
 
 #include <map>
 #include <string>
 #include <vector>
 
@@ skipping 588 matching lines @@
 }
 
 ManagementUninstallFunction::~ManagementUninstallFunction() {
 }
 
 bool ManagementUninstallFunction::RunImpl() {
   scoped_ptr<management::Uninstall::Params> params(
       management::Uninstall::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
-  bool show_confirm_dialog = false;
-  if (params->options.get() && params->options->show_confirm_dialog.get())
-    show_confirm_dialog = *params->options->show_confirm_dialog;
+  bool show_confirm_dialog = true;
+  // By default confirmation dialog isn't shown when uninstalling self, but this
+  // can be overridden with showConfirmDialog.
+  if (extension_ && params->id == extension_->id()) {

[not at google - send to devlin, 2014/01/16 01:13:41]

If you're worried about |extension_| being valid then you should have it as an
EXTENSION_FUNCTION_VALIDATE(extension_), because if this API managed to get
through something odd is going on.

[meacer, 2014/01/16 01:59:19]

Done.

+    show_confirm_dialog = false;
+    if (params->options.get() && params->options->show_confirm_dialog.get())
+      show_confirm_dialog = *params->options->show_confirm_dialog;

[not at google - send to devlin, 2014/01/16 01:13:41]

nit: can you do the above 3 lines in a single expression?

[meacer, 2014/01/16 01:59:19]

Can't think of a better way that won't be confusing. This explains
showConfirmDialog behavior is opposite for normal and self uninstalls and can
only be overriden by self uninstalls.

[not at google - send to devlin, 2014/01/16 05:07:39]

It could be like (inside the is-self check)

show_confirm_dialog = params->options.get() &&
                      params->options->show_confirm_dialog.get() &&
                      *params->options->show_confirm_dialog;

right? though eh, it was just a nit. The conditions here fit into my brain now
that the extension_ check has been moved out.

[meacer, 2014/01/16 18:59:39]

Makes sense.

+  }
+  if (show_confirm_dialog && !user_gesture()) {
+    error_ = keys::kGestureNeededForUninstallError;
+    return false;
+  }
 
   return Uninstall(params->id, show_confirm_dialog);
 }
 
 ManagementUninstallSelfFunction::ManagementUninstallSelfFunction() {
 }
 
 ManagementUninstallSelfFunction::~ManagementUninstallSelfFunction() {
 }
 
@@ skipping 105 matching lines @@
 ProfileKeyedAPIFactory<ManagementAPI>* ManagementAPI::GetFactoryInstance() {
   return &g_factory.Get();
 }
 
 void ManagementAPI::OnListenerAdded(const EventListenerInfo& details) {
   management_event_router_.reset(new ManagementEventRouter(profile_));
   ExtensionSystem::Get(profile_)->event_router()->UnregisterObserver(this);
 }
 
 }  // namespace extensions