Issue 137793010: Use MACOSX_DEPLOYMENT_TARGET instead of SDKROOT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137793010: Use MACOSX_DEPLOYMENT_TARGET instead of SDKROOT. (Closed)

Created:
6 years, 11 months ago by mtklein

Modified:
6 years, 11 months ago

Reviewers:
bungeman-skia

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Use MACOSX_DEPLOYMENT_TARGET instead of SDKROOT. MACOSX_DEPLOYMENT_TARGET is the minimum unconditionally supported OS, which should just be 10.6 for us until Chrome changes. SDKROOT is the maximum conditionally supported OS, which defaults sanely to whatever's the latest SDK the machine has, so we don't need to mention it. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13102

Patch Set 1 #

Patch Set 2 : fix include #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -81 lines)			Patch
M	gyp/common_conditions.gypi	View		3 chunks	+2 lines, -18 lines	0 comments	Download
M	src/views/mac/SkNSView.mm	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
D	tools/find_mac_sdk.py	View		1 chunk	+0 lines, -63 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/137793010/30001

6 years, 11 months ago (2014-01-15 21:26:01 UTC) #3

Message was sent while issue was closed.

Change committed as 13102

Expand Messages | Collapse Messages