Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 13779002: chromeos: Add a subdirectory "file_manager" to chrome/browser/chromeos/extensions (Closed)

Created:
7 years, 8 months ago by hashimoto
Modified:
7 years, 8 months ago
Reviewers:
Lei Zhang, satorux1
CC:
chromium-reviews, sadrul, asanka, Avi (use Gerrit), creis+watch_chromium.org, nkostylev+watch_chromium.org, feature-media-reviews_chromium.org, benjhayden+dwatch_chromium.org, tfarina, ben+watch_chromium.org, Randy Smith (Not in Mondays), sail+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, ajwong+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Add a subdirectory "file_manager" to chrome/browser/chromeos/extensions Create a directory at chrome/browser/chromeos/extensions/file_manager/ Move file_manager_* to the new directory. BUG=224200 TEST=build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192998

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : Fix TranslateManagerTest #

Patch Set 4 : reuploading #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1496 lines) Patch
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/extensions/file_browser_handler_api.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/extensions/file_browser_notifications.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/extensions/file_handler_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/extensions/file_manager/file_manager_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/extensions/file_manager_browsertest.cc View 1 chunk +0 lines, -353 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager_util.h View 1 chunk +0 lines, -106 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager_util.cc View 1 chunk +0 lines, -1014 lines 0 comments Download
M chrome/browser/chromeos/media/media_player.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/platform_util_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/screenshot_taker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/downloads_dom_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
hashimoto
7 years, 8 months ago (2013-04-08 07:55:30 UTC) #1
satorux1
LGTM. You'd need LGTM from chrome/browser/OWNERS
7 years, 8 months ago (2013-04-09 01:34:44 UTC) #2
hashimoto
Lei, Could you review this change as an owner of chrome?
7 years, 8 months ago (2013-04-09 01:37:11 UTC) #3
Lei Zhang
lgtm Though it's odd that the CL shows files like file_browser_event_router.cc as 'D' when they ...
7 years, 8 months ago (2013-04-09 01:50:36 UTC) #4
hashimoto
On 2013/04/09 01:50:36, Lei Zhang wrote: > lgtm > > Though it's odd that the ...
7 years, 8 months ago (2013-04-09 01:55:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/13779002/13002
7 years, 8 months ago (2013-04-09 01:55:36 UTC) #6
hashimoto
7 years, 8 months ago (2013-04-09 03:57:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 manually as r192998 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698