XFA: Remove test for new.

xfa/src/fgas/src/crt/fx_stream.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../fgas_base.h"
 #include "fx_stream.h"
 IFX_Stream* IFX_Stream::CreateStream(IFX_BufferRead* pBufferRead,
                                      FX_DWORD dwAccess,
                                      int32_t iFileSize,
                                      FX_BOOL bReleaseBufferRead) {
   CFX_Stream* pSR = new CFX_Stream;
-  if (!pSR) {
-    return NULL;
-  }
   if (!pSR->LoadBufferRead(pBufferRead, iFileSize, dwAccess,
                            bReleaseBufferRead)) {
     pSR->Release();
     return NULL;
   }
   if (dwAccess & FX_STREAMACCESS_Text) {
-    IFX_Stream* pTR = new CFX_TextStream(pSR, TRUE);
-    if (!pTR) {
-      pTR->Release();
-      pTR = NULL;
-    }
-    return pTR;
+    return new CFX_TextStream(pSR, TRUE);
   }
   return pSR;
 }
 IFX_Stream* IFX_Stream::CreateStream(IFX_FileRead* pFileRead,
                                      FX_DWORD dwAccess) {
   CFX_Stream* pSR = new CFX_Stream;
-  if (pSR == NULL) {
-    return NULL;
-  }
   if (!pSR->LoadFileRead(pFileRead, dwAccess)) {
     pSR->Release();
     return NULL;
   }
   if (dwAccess & FX_STREAMACCESS_Text) {
-    IFX_Stream* pTR = new CFX_TextStream(pSR, TRUE);
-    if (pTR == NULL) {
-      pSR->Release();
-      return NULL;
-    }
-    return pTR;
+    return new CFX_TextStream(pSR, TRUE);
   }
   return pSR;
 }
 IFX_Stream* IFX_Stream::CreateStream(IFX_FileWrite* pFileWrite,
                                      FX_DWORD dwAccess) {
   CFX_Stream* pSR = new CFX_Stream;
-  if (pSR == NULL) {
-    return NULL;
-  }
   if (!pSR->LoadFileWrite(pFileWrite, dwAccess)) {
     pSR->Release();
     return NULL;
   }
   if (dwAccess & FX_STREAMACCESS_Text) {
-    IFX_Stream* pTR = new CFX_TextStream(pSR, TRUE);
-    if (pTR == NULL) {
-      pSR->Release();
-      return NULL;
-    }
-    return pTR;
+    return new CFX_TextStream(pSR, TRUE);
   }
   return pSR;
 }
 IFX_Stream* IFX_Stream::CreateStream(const FX_WCHAR* pszFileName,
                                      FX_DWORD dwAccess) {
   CFX_Stream* pSR = new CFX_Stream;
-  if (pSR == NULL) {
-    return NULL;
-  }
   if (!pSR->LoadFile(pszFileName, dwAccess)) {
     pSR->Release();
     return NULL;
   }
   if (dwAccess & FX_STREAMACCESS_Text) {
-    IFX_Stream* pTR = new CFX_TextStream(pSR, TRUE);
-    if (pTR == NULL) {
-      pSR->Release();
-      return NULL;
-    }
-    return pTR;
+    return new CFX_TextStream(pSR, TRUE);
   }
   return pSR;
 }
 IFX_Stream* IFX_Stream::CreateStream(uint8_t* pData,
                                      int32_t length,
                                      FX_DWORD dwAccess) {
   CFX_Stream* pSR = new CFX_Stream;
-  if (pSR == NULL) {
-    return NULL;
-  }
   if (!pSR->LoadBuffer(pData, length, dwAccess)) {
     pSR->Release();
     return NULL;
   }
   if (dwAccess & FX_STREAMACCESS_Text) {
-    IFX_Stream* pTR = new CFX_TextStream(pSR, TRUE);
-    if (pTR == NULL) {
-      pSR->Release();
-      return NULL;
-    }
-    return pTR;
+    return new CFX_TextStream(pSR, TRUE);
   }
   return pSR;
 }
 CFX_StreamImp::CFX_StreamImp() : CFX_ThreadLock(), m_dwAccess(0) {}
 CFX_FileStreamImp::CFX_FileStreamImp()
     : CFX_StreamImp(), m_hFile(NULL), m_iLength(0) {}
 CFX_FileStreamImp::~CFX_FileStreamImp() {
   if (m_hFile != NULL) {
     FXSYS_fclose(m_hFile);
   }
@@ skipping 651 matching lines @@
 }
 IFX_Stream* CFX_TextStream::CreateSharedStream(FX_DWORD dwAccess,
                                                int32_t iOffset,
                                                int32_t iLength) {
   IFX_Stream* pSR =
       m_pStreamImp->CreateSharedStream(dwAccess, iOffset, iLength);
   if (pSR == NULL) {
     return NULL;
   }
   if (dwAccess & FX_STREAMACCESS_Text) {
-    IFX_Stream* pTR = new CFX_TextStream(pSR, TRUE);
-    if (pTR == NULL) {
-      pSR->Release();
-      return NULL;
-    }
-    return pTR;
+    return new CFX_TextStream(pSR, TRUE);
   }
   return pSR;
 }
 int32_t CFX_TextStream::GetBOM(uint8_t bom[4]) const {
   if (m_wBOMLength < 1) {
     return 0;
   }
   *(FX_DWORD*)bom = m_dwBOM;
   return (int32_t)m_wBOMLength;
 }
@@ skipping 97 matching lines @@
 }
 FX_BOOL CFX_Stream::LoadFile(const FX_WCHAR* pszSrcFileName,
                              FX_DWORD dwAccess) {
   if (m_eStreamType != FX_SREAMTYPE_Unknown || m_pStreamImp != NULL) {
     return FALSE;
   }
   if (pszSrcFileName == NULL || FXSYS_wcslen(pszSrcFileName) < 1) {
     return FALSE;
   }
   m_pStreamImp = new CFX_FileStreamImp();
-  if (m_pStreamImp == NULL) {
-    return FALSE;
-  }
   FX_BOOL bRet =
       ((CFX_FileStreamImp*)m_pStreamImp)->LoadFile(pszSrcFileName, dwAccess);
   if (!bRet) {
     m_pStreamImp->Release();
     m_pStreamImp = NULL;
   } else {
     m_eStreamType = FX_STREAMTYPE_File;
     m_dwAccess = dwAccess;
     m_iLength = m_pStreamImp->GetLength();
   }
   return bRet;
 }
 FX_BOOL CFX_Stream::LoadFileRead(IFX_FileRead* pFileRead, FX_DWORD dwAccess) {
   if (m_eStreamType != FX_SREAMTYPE_Unknown || m_pStreamImp != NULL) {
     return FALSE;
   }
   if (pFileRead == NULL) {
     return FALSE;
   }
   m_pStreamImp = new CFX_FileReadStreamImp();
-  if (m_pStreamImp == NULL) {
-    return FALSE;
-  }
   FX_BOOL bRet =
       ((CFX_FileReadStreamImp*)m_pStreamImp)->LoadFileRead(pFileRead, dwAccess);
   if (!bRet) {
     m_pStreamImp->Release();
     m_pStreamImp = NULL;
   } else {
     m_eStreamType = FX_STREAMTYPE_File;
     m_dwAccess = dwAccess;
     m_iLength = m_pStreamImp->GetLength();
   }
   return bRet;
 }
 FX_BOOL CFX_Stream::LoadFileWrite(IFX_FileWrite* pFileWrite,
                                   FX_DWORD dwAccess) {
   if (m_eStreamType != FX_SREAMTYPE_Unknown || m_pStreamImp != NULL) {
     return FALSE;
   }
   if (pFileWrite == NULL) {
     return FALSE;
   }
   m_pStreamImp = new CFX_FileWriteStreamImp();
-  if (m_pStreamImp == NULL) {
-    return FALSE;
-  }
   FX_BOOL bRet = ((CFX_FileWriteStreamImp*)m_pStreamImp)
                      ->LoadFileWrite(pFileWrite, dwAccess);
   if (!bRet) {
     m_pStreamImp->Release();
     m_pStreamImp = NULL;
   } else {
     m_eStreamType = FX_STREAMTYPE_File;
     m_dwAccess = dwAccess;
     m_iLength = m_pStreamImp->GetLength();
   }
   return bRet;
 }
 FX_BOOL CFX_Stream::LoadBuffer(uint8_t* pData,
                                int32_t iTotalSize,
                                FX_DWORD dwAccess) {
   if (m_eStreamType != FX_SREAMTYPE_Unknown || m_pStreamImp != NULL) {
     return FALSE;
   }
   if (pData == NULL || iTotalSize < 1) {
     return FALSE;
   }
   m_pStreamImp = new CFX_BufferStreamImp();
-  if (m_pStreamImp == NULL) {
-    return FALSE;
-  }
   FX_BOOL bRet = ((CFX_BufferStreamImp*)m_pStreamImp)
                      ->LoadBuffer(pData, iTotalSize, dwAccess);
   if (!bRet) {
     m_pStreamImp->Release();
     m_pStreamImp = NULL;
   } else {
     m_eStreamType = FX_STREAMTYPE_Buffer;
     m_dwAccess = dwAccess;
     m_iLength = m_pStreamImp->GetLength();
   }
   return bRet;
 }
 FX_BOOL CFX_Stream::LoadBufferRead(IFX_BufferRead* pBufferRead,
                                    int32_t iFileSize,
                                    FX_DWORD dwAccess,
                                    FX_BOOL bReleaseBufferRead) {
   if (m_eStreamType != FX_SREAMTYPE_Unknown || m_pStreamImp != NULL) {
     return FALSE;
   }
   if (!pBufferRead) {
     return FALSE;
   }
   m_pStreamImp = new CFX_BufferReadStreamImp;
-  if (m_pStreamImp == NULL) {
-    return FALSE;
-  }
   FX_BOOL bRet = ((CFX_BufferReadStreamImp*)m_pStreamImp)
                      ->LoadBufferRead(pBufferRead, iFileSize, dwAccess,
                                       bReleaseBufferRead);
   if (!bRet) {
     m_pStreamImp->Release();
     m_pStreamImp = NULL;
   } else {
     m_eStreamType = FX_STREAMTYPE_BufferRead;
     m_dwAccess = dwAccess;
     m_iLength = m_pStreamImp->GetLength();
@@ skipping 223 matching lines @@
   register int32_t iStart = m_iStart + iOffset;
   register int32_t iTotal = m_iStart + m_iLength;
   if (iStart < m_iStart || iStart >= iTotal) {
     return NULL;
   }
   register int32_t iEnd = iStart + iLength;
   if (iEnd < iStart || iEnd > iTotal) {
     return NULL;
   }
   CFX_Stream* pShared = new CFX_Stream;
-  if (pShared == NULL) {
-    return NULL;
-  }
   pShared->m_eStreamType = FX_STREAMTYPE_Stream;
   pShared->m_pStreamImp = m_pStreamImp;
   pShared->m_dwAccess = dwAccess;
   pShared->m_iTotalSize = iLength;
   pShared->m_iPosition = iStart;
   pShared->m_iStart = iStart;
   pShared->m_iLength = (dwAccess & FX_STREAMACCESS_Write) != 0 ? 0 : iLength;
   if (dwAccess & FX_STREAMACCESS_Text) {
     return IFX_Stream::CreateTextStream(pShared, TRUE);
   }
@@ skipping 295 matching lines @@
 FX_BOOL CFGAS_FileWrite::WriteBlock(const void* pData,
                                     FX_DWORD offset,
                                     FX_DWORD size) {
   m_pStream->Lock();
   m_pStream->Seek(FX_STREAMSEEK_Begin, offset);
   int32_t iLen = m_pStream->WriteData((uint8_t*)pData, (int32_t)size);
   m_pStream->Unlock();
   return iLen == (int32_t)size;
 }
 #endif