Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 1377833002: Make AstPrinter print position information. (Closed)

Created:
5 years, 2 months ago by neis
Modified:
5 years, 2 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make AstPrinter print position information. R=rossberg BUG= Committed: https://crrev.com/4620029c4bbd5f9cff65214510b21d70bf2ee214 Cr-Commit-Position: refs/heads/master@{#31021}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -46 lines) Patch
M src/prettyprinter.cc View 24 chunks +53 lines, -46 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
neis
5 years, 2 months ago (2015-09-29 14:11:26 UTC) #1
rossberg
lgtm
5 years, 2 months ago (2015-09-30 13:31:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377833002/1
5 years, 2 months ago (2015-09-30 13:59:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 14:23:04 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 14:23:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4620029c4bbd5f9cff65214510b21d70bf2ee214
Cr-Commit-Position: refs/heads/master@{#31021}

Powered by Google App Engine
This is Rietveld 408576698