Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: Source/build/scripts/templates/MakeQualifiedNames.h.tmpl

Issue 137783012: MakeQualifiedNames should generate lazily created arrays for attributes and tags. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/build/scripts/templates/MakeQualifiedNames.h.tmpl
diff --git a/Source/build/scripts/templates/MakeQualifiedNames.h.tmpl b/Source/build/scripts/templates/MakeQualifiedNames.h.tmpl
index 7c614c787b4ed0d79627da08d0fa4204443c70dd..8f8dc3b5ba7cea7767c3e337df9ab04f3fa6ca84 100644
--- a/Source/build/scripts/templates/MakeQualifiedNames.h.tmpl
+++ b/Source/build/scripts/templates/MakeQualifiedNames.h.tmpl
@@ -5,6 +5,7 @@
#define {{namespace}}Names_h
#include "core/dom/QualifiedName.h"
+#include "wtf/PassOwnPtr.h"
namespace WebCore {
namespace {{namespace}}Names {
@@ -27,10 +28,10 @@ extern const WebCore::QualifiedName {{attr|symbol}}Attr;
{%- if tags %}
const unsigned {{namespace}}TagsCount = {{tags|count}};
-const WebCore::QualifiedName* const* get{{namespace}}Tags();
+PassOwnPtr<const QualifiedName*[]> get{{namespace}}Tags();
{%- endif %}
const unsigned {{namespace}}AttrsCount = {{attrs|count}};
-const WebCore::QualifiedName* const* get{{namespace}}Attrs();
+PassOwnPtr<const QualifiedName*[]> get{{namespace}}Attrs();
void init();
« no previous file with comments | « Source/build/scripts/templates/MakeQualifiedNames.cpp.tmpl ('k') | Source/core/html/parser/HTMLTreeBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698