Source/build/scripts/templates/MakeQualifiedNames.h.tmpl - Issue 137783012: MakeQualifiedNames should generate lazily created arrays for attributes and tags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/build/scripts/templates/MakeQualifiedNames.h.tmpl

Issue 137783012: MakeQualifiedNames should generate lazily created arrays for attributes and tags. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/build/scripts/templates/MakeQualifiedNames.cpp.tmpl ('k') | Source/core/html/parser/HTMLTreeBuilder.cpp » ('j') | Source/core/html/parser/HTMLTreeBuilder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/build/scripts/templates/MakeQualifiedNames.h.tmpl

diff --git a/Source/build/scripts/templates/MakeQualifiedNames.h.tmpl b/Source/build/scripts/templates/MakeQualifiedNames.h.tmpl

index 7c614c787b4ed0d79627da08d0fa4204443c70dd..ce3a14a682e90b2fd505e39c09990a85d6c4e60e 100644

--- a/Source/build/scripts/templates/MakeQualifiedNames.h.tmpl

+++ b/Source/build/scripts/templates/MakeQualifiedNames.h.tmpl

@@ -27,10 +27,10 @@ extern const WebCore::QualifiedName {{attr|symbol}}Attr;

{%- if tags %}

const unsigned {{namespace}}TagsCount = {{tags|count}};

-const WebCore::QualifiedName* const* get{{namespace}}Tags();

+void get{{namespace}}Tags(WebCore::QualifiedName* tags[], unsigned length);

Inactive 2014/01/15 19:27:02 Passing the length here is a bit odd. Maybe, we ca

{%- endif %}

const unsigned {{namespace}}AttrsCount = {{attrs|count}};

-const WebCore::QualifiedName* const* get{{namespace}}Attrs();

+void get{{namespace}}Attrs(WebCore::QualifiedName* attributes[], unsigned length);

void init();