Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 137783011: Revert "Eliminatable CheckMaps replaced with if(true) or if(false)." (Closed)

Created:
6 years, 11 months ago by Jakob Kummerow
Modified:
6 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Revert "Eliminatable CheckMaps replaced with if(true) or if(false)." This reverts r18592 for breaking the GC stress bots. R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -68 lines) Patch
M src/hydrogen.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +0 lines, -33 lines 0 comments Download
M src/hydrogen-check-elimination.cc View 2 chunks +4 lines, -19 lines 0 comments Download
M src/hydrogen-flow-engine.h View 2 chunks +10 lines, -13 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
6 years, 11 months ago (2014-01-15 09:50:43 UTC) #1
Michael Achenbach
On 2014/01/15 09:50:43, Jakob wrote: lgtm
6 years, 11 months ago (2014-01-15 09:51:12 UTC) #2
Jakob Kummerow
6 years, 11 months ago (2014-01-15 09:54:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18611.

Powered by Google App Engine
This is Rietveld 408576698