Issue 137783010: Remove unused HTMLTextFormControlElement::maxLength.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137783010: Remove unused HTMLTextFormControlElement::maxLength. (Closed)

Created:
6 years, 11 months ago by tkent

Modified:
6 years, 11 months ago

Reviewers:
keishi

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove unused HTMLTextFormControlElement::maxLength. No one calls maxLength for HTMLTextFormControlElement though HTMLInputElement::maxLength and HTMLTextAreaElement::maxLength are used. We can remove HTMLTextFormControlElement::maxLength, and stop overriding it in HTMLInputElement and HTMLTextAreaElement. BUG=none TEST=none; no behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165129

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -3 lines)			Patch
M	Source/core/html/HTMLInputElement.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLTextAreaElement.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLTextFormControlElement.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/137783010/1

6 years, 11 months ago (2014-01-15 08:17:12 UTC) #3

Message was sent while issue was closed.

Change committed as 165129

Expand Messages | Collapse Messages