Start in elevated mode when creating a new managed user profile.

chrome/browser/ui/webui/options/managed_user_settings_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/managed_user_settings_handler.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/time.h"
 #include "base/values.h"
-#include "chrome/browser/first_run/first_run.h"
 #include "chrome/browser/managed_mode/managed_mode_navigation_observer.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_ui.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/google_chrome_strings.h"
 #include "grit/locale_settings.h"
@@ skipping 15 matching lines @@
       base::Bind(&ManagedUserSettingsHandler::OnLocalPassphraseChanged,
                  base::Unretained(this)));
 }
 
 void ManagedUserSettingsHandler::InitializePage() {
   if (!CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kEnableManagedUsers)) {
     return;
   }
   PrefService* pref_service = Profile::FromWebUI(web_ui())->GetPrefs();
-  base::FundamentalValue is_passphrase_set(!pref_service->GetString(
-      prefs::kManagedModeLocalPassphrase).empty());
+  bool passphrase_empty =
+      pref_service->GetString(prefs::kManagedModeLocalPassphrase).empty();
+  base::FundamentalValue is_passphrase_set(!passphrase_empty);
   web_ui()->CallJavascriptFunction(
       "ManagedUserSettings.passphraseChanged",
       is_passphrase_set);
-  if ((first_run::IsChromeFirstRun() &&
-       !CommandLine::ForCurrentProcess()->HasSwitch(switches::kNoFirstRun)) ||
-      CommandLine::ForCurrentProcess()->HasSwitch(
-          switches::kResetLocalPassphrase)) {
+  if (!HasSeenSetupDialog() ||
+      (CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kResetLocalPassphrase) &&
+       passphrase_empty)) {

[Bernhard Bauer, 2013/04/08 12:26:09]

Why are we checking for an empty passphrase when kResetLocalPassphrase is set?

[Adrian Kuegel, 2013/04/08 14:31:04]

This method is called whenever the settings frame is reloaded, so if I don't
check for the passphrase to be empty, it could happen that a new passphrase was
already set, but still the settings page is opened in authenticated state the
next time during the same browser run.

     ManagedModeNavigationObserver::FromWebContents(
         web_ui()->GetWebContents())->set_elevated(true);
   }
 }
 
 void ManagedUserSettingsHandler::HandlePageOpened(const base::ListValue* args) {
   start_time_ = base::TimeTicks::Now();
   content::RecordAction(UserMetricsAction("ManagedMode_OpenSettings"));
   if (ManagedModeNavigationObserver::FromWebContents(
       web_ui()->GetWebContents())->is_elevated()) {
@@ skipping 42 matching lines @@
   web_ui()->RegisterMessageCallback(
       "confirmManagedUserSettings",
       base::Bind(&ManagedUserSettingsHandler::SaveMetrics,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "settingsPageOpened",
       base::Bind(&ManagedUserSettingsHandler::HandlePageOpened,
                  base::Unretained(this)));
 }
 
+bool ManagedUserSettingsHandler::HasSeenSetupDialog() {
+  PrefService* pref_service = Profile::FromWebUI(web_ui())->GetPrefs();
+  return pref_service->GetBoolean(prefs::kManagedModeHasSeenSetupDialog);
+}
+
 void ManagedUserSettingsHandler::SaveMetrics(const ListValue* args) {
-  if (first_run::IsChromeFirstRun()) {
+  if (!HasSeenSetupDialog()) {
+    PrefService* pref_service = Profile::FromWebUI(web_ui())->GetPrefs();
+    pref_service->SetBoolean(prefs::kManagedModeHasSeenSetupDialog, true);
     UMA_HISTOGRAM_LONG_TIMES("ManagedMode.UserSettingsFirstRunTime",
                              base::TimeTicks::Now() - start_time_);
   } else {
     UMA_HISTOGRAM_LONG_TIMES("ManagedMode.UserSettingsModifyTime",
                              base::TimeTicks::Now() - start_time_);
   }
 }
 
 void ManagedUserSettingsHandler::OnLocalPassphraseChanged() {
   PrefService* pref_service = Profile::FromWebUI(web_ui())->GetPrefs();
   base::FundamentalValue is_passphrase_set(!pref_service->GetString(
       prefs::kManagedModeLocalPassphrase).empty());
   web_ui()->CallJavascriptFunction("ManagedUserSettings.passphraseChanged",
                                    is_passphrase_set);
 }
 
 }  // namespace options