Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1377793004: Isolate sql_unittests_apk. (Closed)

Created:
5 years, 2 months ago by ghost stip (do not use)
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Isolate sql_unittests_apk. BUG=525873 Committed: https://crrev.com/21383131e6b3c0b55759de7c518967a9a6105cc2 Cr-Commit-Position: refs/heads/master@{#352237}

Patch Set 1 #

Patch Set 2 : Actual isolate file this time. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M sql/sql.gyp View 1 chunk +19 lines, -0 lines 0 comments Download
A sql/sql_unittests_apk.isolate View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ghost stip (do not use)
maruel/jbudorick: ptal shess: OWNERS
5 years, 2 months ago (2015-10-02 22:50:24 UTC) #2
Scott Hess - ex-Googler
rubber-stamp LGTM <dog-who-doesn't-understand-what-he's-doing/>
5 years, 2 months ago (2015-10-02 22:51:56 UTC) #3
ghost stip (do not use)
the best kind of lg!
5 years, 2 months ago (2015-10-02 22:55:50 UTC) #4
M-A Ruel
lgtm
5 years, 2 months ago (2015-10-02 23:39:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377793004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377793004/20001
5 years, 2 months ago (2015-10-02 23:41:01 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-03 04:53:45 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-03 04:54:31 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/21383131e6b3c0b55759de7c518967a9a6105cc2
Cr-Commit-Position: refs/heads/master@{#352237}

Powered by Google App Engine
This is Rietveld 408576698