Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: CONTRIBUTING.md

Issue 1377773003: Update CONTRIBUTING.md, test CQ (Closed) Base URL: git@github.com:GoogleChrome/custom-tabs-client.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Contributing to the Custom Tabs Examples
1 Want to contribute? Great! First, read this page (including the small print at t he end). 2 Want to contribute? Great! First, read this page (including the small print at t he end).
2 3
3 ### Before you contribute 4 ### Before you contribute
4 Before we can use your code, you must sign the 5 Before we can use your code, you must sign the
5 [Google Individual Contributor License Agreement](https://developers.google.com/ open-source/cla/individual?csw=1) 6 [Google Individual Contributor License Agreement](https://developers.google.com/ open-source/cla/individual?csw=1)
6 (CLA), which you can do online. The CLA is necessary mainly because you own the 7 (CLA), which you can do online. The CLA is necessary mainly because you own the
7 copyright to your changes, even after your contribution becomes part of our 8 copyright to your changes, even after your contribution becomes part of our
8 codebase, so we need your permission to use and distribute your code. We also 9 codebase, so we need your permission to use and distribute your code. We also
9 need to be sure of various other things—for instance that you'll tell us if you 10 need to be sure of various other things—for instance that you'll tell us if you
10 know that your code infringes on other people's patents. You don't have to sign 11 know that your code infringes on other people's patents. You don't have to sign
11 the CLA until after you've submitted your code for review and a member has 12 the CLA until after you've submitted your code for review and a member has
12 approved it, but you must do it before we can put your code into our codebase. 13 approved it, but you must do it before we can put your code into our codebase.
13 Before you start working on a larger contribution, you should get in touch with 14 Before you start working on a larger contribution, you should get in touch with
14 us first through the issue tracker with your idea so that we can help out and 15 us first through the issue tracker with your idea so that we can help out and
15 possibly guide you. Coordinating up front makes it much easier to avoid 16 possibly guide you. Coordinating up front makes it much easier to avoid
16 frustration later on. 17 frustration later on.
17 18
18 ### Code reviews 19 ### Code reviews
19 All submissions, including submissions by project members, require review. We 20 All submissions, including submissions by project members, require review. We
20 use http://codereview.chromium.org for this purpose. 21 use http://codereview.chromium.org for this purpose. The process will be very
22 similar to the one used in the [Catapult
23 Project](https://github.com/catapult-project/catapult/blob/master/CONTRIBUTING.m d).
24 More details soon.
21 25
22 ### The small print 26 ### The small print
23 Contributions made by corporations are covered by a different agreement than 27 Contributions made by corporations are covered by a different agreement than
24 the one above, the Software Grant and Corporate Contributor License Agreement. 28 the one above, the Software Grant and Corporate Contributor License Agreement.
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698