Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1377733007: Error quickly if the embedder tries to load after Dart_Precompile. (Closed)

Created:
5 years, 2 months ago by rmacnak
Modified:
5 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Error quickly if the embedder tries to load after Dart_Precompile. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/26c187d818d2a0316c6a6ceec3484b44ab40c998

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M runtime/vm/dart_api_impl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 6 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 2 months ago (2015-10-02 17:48:27 UTC) #2
srdjan
lgtm
5 years, 2 months ago (2015-10-02 17:58:36 UTC) #3
rmacnak
5 years, 2 months ago (2015-10-06 17:14:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
26c187d818d2a0316c6a6ceec3484b44ab40c998 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698