Fixes for contenteditable caret and selection handling in Windows.

Fixes for contenteditable caret and selection handling in Windows.

1. Reports a valid selection endpoint even when either the start or end of the selection fall outside the object.
<div contenteditable>this <selection_start>is a <a href="#">link<selection_end></a>.</div>
selection_start on the link element would be given as 0.
2. Does not report any selection on a parent object if there is no selection on the child objects.
<div contenteditable><p>hi</p></div>
nSelections on the div should be 0.
BUG=527440
R=dmazzoni@chromium.org

Committed: https://crrev.com/d816a9211de3c355f0de5051fa5c517ef2321e1a
Cr-Commit-Position: refs/heads/master@{#352236}

[dmazzoni, 2015-09-30 20:09:56]

lgtm

https://codereview.chromium.org/1377733002/diff/80001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/1377733002/diff/80001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:3722: 
Please remove the double blank lines within a function

https://codereview.chromium.org/1377733002/diff/80001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:3731: //
TODO(nektar): Add a const version of ToBrowserAccessibilityWin.
Please just do this as part of this changelist

https://codereview.chromium.org/1377733002/diff/80001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:3740: const
BrowserAccessibilityWin* non_text_this = IsTextOnlyObject() ?
how about nearest_non_text_ancestor

https://codereview.chromium.org/1377733002/diff/80001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:3744:
*(endpoint_object.GetParent()->ToBrowserAccessibilityWin()) :
I'd indent this and the next line 4 more spaces because they're part of the
ternary operator expression

https://codereview.chromium.org/1377733002/diff/80001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:3761: int32
current_offset = static_cast<int>(
nit: <int32> to match the type you're assigning to

https://codereview.chromium.org/1377733002/diff/80001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_win.h (right):

https://codereview.chromium.org/1377733002/diff/80001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.h:778: // If the
selection endpoint is either equal to or an ancestor of this object,
Comment should mention when it returns -1 and why

[chromium-reviews, 2015-10-01 00:15:26]

Done, except:
int32 current_offset = static_cast<int>(...);
I prefer to change the type instead of the cast:
int current_offset = static_cast<int>(...);

Also, I removed all the get_hyperlink lines from the end of 
GetSelectionOffsets and replaced them with a call to a new method I 
added HasSelection. I then modified get_nselections to use this new 
method instead of GetSelectionOffsets.
HasSelection is more efficient than having to retrieve the actual 
offsets. It just checks if anchor and focus are valid and not the same.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nektarios, 2015-10-01 21:22:20]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2015-10-01 21:22:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1377733002/#ps160001
(title: "Last uploda.")

[commit-bot: I haz the power, 2015-10-01 21:22:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377733002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377733002/160001

[commit-bot: I haz the power, 2015-10-01 21:31:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 21:31:23]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nektarios, 2015-10-01 21:50:51]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2015-10-01 21:50:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1377733002/#ps180001
(title: "Rebased with master.")

[commit-bot: I haz the power, 2015-10-01 21:52:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377733002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377733002/180001

[commit-bot: I haz the power, 2015-10-01 21:59:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 21:59:46]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[nektarios, 2015-10-03 02:06:08]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2015-10-03 02:06:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1377733002/#ps260001
(title: "Fixed one more corner case.")

[commit-bot: I haz the power, 2015-10-03 02:07:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377733002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377733002/260001

[commit-bot: I haz the power, 2015-10-03 04:15:22]

Committed patchset #14 (id:260001)

[commit-bot: I haz the power, 2015-10-03 04:16:03]

Patchset 14 (id:??) landed as
https://crrev.com/d816a9211de3c355f0de5051fa5c517ef2321e1a
Cr-Commit-Position: refs/heads/master@{#352236}

[nektarios, 2015-10-03 04:46:23]

A revert of this CL (patchset #14 id:260001) has been created in
https://codereview.chromium.org/1388593002/ by nektar@chromium.org.

The reason for reverting is: Breaks reporting of the selection when the focus is
on a text leaf that is not an immediate sibling of the nearest non-text ancestor
of the current object..

[nektarios, 2015-10-03 04:46:27]

A revert of this CL (patchset #14 id:260001) has been created in
https://codereview.chromium.org/1381603005/ by nektar@chromium.org.

The reason for reverting is: Breaks reporting of the selection when the focus is
on a text leaf that is not an immediate sibling of the nearest non-text ancestor
of the current object..