Issue 137773002: Cleanup IDL test files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137773002: Cleanup IDL test files (Closed)

Created:
6 years, 11 months ago by Nils Barth (inactive)

Modified:
6 years, 11 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Cleanup IDL test files Some fixes to IDL test files: * Move SVG tests to separate TestSVG.idl, as we will not need these in future (so we can just delete this test case when SVG rewrite complete) Remove as unused in real IDL files: * callback interface arguments in constructors * nullable array Style fix to TestTypedefs: * typedefs at *top* of file BUG=239771 TBR=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165017

Patch Set 1 #

Patch Set 2 : Fix SVG #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+466 lines, -358 lines)			Patch
M	Source/bindings/tests/idls/TestObject.idl	View	1	3 chunks	+0 lines, -12 lines	0 comments	Download
A +	Source/bindings/tests/idls/TestSVG.idl	View		1 chunk	+12 lines, -8 lines	0 comments	Download
M	Source/bindings/tests/idls/TestTypedefs.idl	View		3 chunks	+13 lines, -17 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestObject.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestObject.cpp	View	1	12 chunks	+0 lines, -252 lines	0 comments	Download
A +	Source/bindings/tests/results/V8TestSVG.h	View		1 chunk	+29 lines, -29 lines	0 comments	Download
A	Source/bindings/tests/results/V8TestSVG.cpp	View		1 chunk	+390 lines, -0 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestTypedefs.cpp	View		6 chunks	+21 lines, -39 lines	0 comments	Download
M	Tools/Scripts/webkitpy/bindings/main.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/137773002/20001

6 years, 11 months ago (2014-01-14 02:34:06 UTC) #3

Message was sent while issue was closed.

Change committed as 165017

Expand Messages | Collapse Messages