Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1377723003: [heap] Refactor and clean up FreeListCategory. (Closed)

Created:
5 years, 2 months ago by Michael Lippautz
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Refactor and clean up FreeListCategory. BUG= Committed: https://crrev.com/1d998bd0a6297a282739ff976bba7ebeb149fea6 Cr-Commit-Position: refs/heads/master@{#31048}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -67 lines) Patch
M src/heap/spaces.h View 4 chunks +54 lines, -21 lines 1 comment Download
M src/heap/spaces.cc View 5 chunks +57 lines, -46 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Lippautz
https://codereview.chromium.org/1377723003/diff/1/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/1377723003/diff/1/src/heap/spaces.h#newcode755 src/heap/spaces.h:755: enum FreeListCategoryType { kSmall, kMedium, kLarge, kHuge }; This ...
5 years, 2 months ago (2015-10-01 12:06:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377723003/1
5 years, 2 months ago (2015-10-01 12:25:21 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-01 13:12:50 UTC) #6
Hannes Payer (out of office)
On 2015/10/01 13:12:50, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 2 months ago (2015-10-01 13:13:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377723003/1
5 years, 2 months ago (2015-10-01 13:15:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-01 13:17:09 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 13:17:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d998bd0a6297a282739ff976bba7ebeb149fea6
Cr-Commit-Position: refs/heads/master@{#31048}

Powered by Google App Engine
This is Rietveld 408576698