Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1377723002: MD Settings: update a11y section (Closed)

Created:
5 years, 2 months ago by Dan Beam
Modified:
5 years, 2 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: update a11y section 1) Make ChromeOS-only because desktop showing just "ADD MORES FEATURES" is odd 2) Account for 1) in C++ and .grds and HTML and ... 3) Add explanation + learn more link on top of a11y section on ChromeOS R=michaelpg@chromium.org BUG=537048 Committed: https://crrev.com/bd7cfd3aa45475b37ef095b8b5d91c03c2b39ac2 Cr-Commit-Position: refs/heads/master@{#351334}

Patch Set 1 #

Total comments: 6

Patch Set 2 : michaelpg@ review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -77 lines) Patch
M chrome/app/settings_strings.grdp View 1 2 chunks +75 lines, -68 lines 0 comments Download
M chrome/browser/resources/settings/a11y_page/a11y_page.html View 2 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/resources/settings/a11y_page/a11y_page.js View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/advanced_page/advanced_page.html View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_page.css View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 4 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Dan Beam
5 years, 2 months ago (2015-09-29 02:24:58 UTC) #1
michaelpg
lgtm https://codereview.chromium.org/1377723002/diff/1/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/1377723002/diff/1/chrome/app/settings_strings.grdp#newcode9 chrome/app/settings_strings.grdp:9: <if expr="chromeos"> nit: unlike in html, the <if>s ...
5 years, 2 months ago (2015-09-29 03:10:20 UTC) #2
Dan Beam
https://codereview.chromium.org/1377723002/diff/1/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/1377723002/diff/1/chrome/app/settings_strings.grdp#newcode9 chrome/app/settings_strings.grdp:9: <if expr="chromeos"> On 2015/09/29 03:10:20, michaelpg wrote: > nit: ...
5 years, 2 months ago (2015-09-29 03:39:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377723002/20001
5 years, 2 months ago (2015-09-29 03:40:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/126707)
5 years, 2 months ago (2015-09-29 04:09:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377723002/20001
5 years, 2 months ago (2015-09-29 06:22:17 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/126760)
5 years, 2 months ago (2015-09-29 06:41:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377723002/20001
5 years, 2 months ago (2015-09-29 16:16:30 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-29 16:28:49 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 16:30:37 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd7cfd3aa45475b37ef095b8b5d91c03c2b39ac2
Cr-Commit-Position: refs/heads/master@{#351334}

Powered by Google App Engine
This is Rietveld 408576698