MD Settings: update a11y section

MD Settings: update a11y section

1) Make ChromeOS-only because desktop showing just "ADD MORES FEATURES" is odd
2) Account for 1) in C++ and .grds and HTML and ...
3) Add explanation + learn more link on top of a11y section on ChromeOS

R=michaelpg@chromium.org
BUG=537048
Committed: https://crrev.com/bd7cfd3aa45475b37ef095b8b5d91c03c2b39ac2
Cr-Commit-Position: refs/heads/master@{#351334}

[michaelpg, 2015-09-29 03:10:20]

lgtm

https://codereview.chromium.org/1377723002/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/1377723002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:9: <if expr="chromeos">
nit: unlike in html, the <if>s I've seen in .grd[p] files are part of the normal
indentation stack

https://codereview.chromium.org/1377723002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/a11y_page/a11y_page.js (right):

https://codereview.chromium.org/1377723002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/a11y_page/a11y_page.js:35:
window.open('https://chrome.google.com/webstore/category/collection/accessibility');
*eyes narrow*

fine by me, but this would be exactly 80 chars if you break after the open-paren

https://codereview.chromium.org/1377723002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/advanced_page/advanced_page.html (right):

https://codereview.chromium.org/1377723002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/advanced_page/advanced_page.html:58:
<cr-settings-section i18n-values="page-title:a11yPageTitle"
todo: make this route chrome-os-only. perhaps via something somewhat similar to
https://codereview.chromium.org/1374813003/diff/1/chrome/browser/resources/se...

[Dan Beam, 2015-09-29 03:39:25]

https://codereview.chromium.org/1377723002/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/1377723002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:9: <if expr="chromeos">
On 2015/09/29 03:10:20, michaelpg wrote:
> nit: unlike in html, the <if>s I've seen in .grd[p] files are part of the
normal
> indentation stack

in the HTML they're 0-indented to look like pre-processor statements.  i don't
really see how that's different in .grd files.

while searching for:

  file:.*grd.* \s<if\s

vs

  file:.*grd.* ^<if\s

on code search it seems we're consistent with not 0-indenting, so you win this
round (and easily blaming the code loses)

https://codereview.chromium.org/1377723002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/a11y_page/a11y_page.js (right):

https://codereview.chromium.org/1377723002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/a11y_page/a11y_page.js:35:
window.open('https://chrome.google.com/webstore/category/collection/accessibility');
On 2015/09/29 03:10:20, michaelpg wrote:
> *eyes narrow*
> 
> fine by me, but this would be exactly 80 chars if you break after the
open-paren

Done.

https://codereview.chromium.org/1377723002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/advanced_page/advanced_page.html (right):

https://codereview.chromium.org/1377723002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/advanced_page/advanced_page.html:58:
<cr-settings-section i18n-values="page-title:a11yPageTitle"
On 2015/09/29 03:10:20, michaelpg wrote:
> todo: make this route chrome-os-only. perhaps via something somewhat similar
to
>
https://codereview.chromium.org/1374813003/diff/1/chrome/browser/resources/se...

there's no route for this page yet

[Dan Beam, 2015-09-29 03:40:19]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2015-09-29 03:40:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1377723002/#ps20001
(title: "michaelpg@ review")

[commit-bot: I haz the power, 2015-09-29 03:40:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377723002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377723002/20001

[commit-bot: I haz the power, 2015-09-29 04:09:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-29 04:09:33]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Dan Beam, 2015-09-29 06:22:12]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-09-29 06:22:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377723002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377723002/20001

[commit-bot: I haz the power, 2015-09-29 06:41:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-29 06:41:09]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Dan Beam, 2015-09-29 16:15:37]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-09-29 16:16:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377723002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377723002/20001

[commit-bot: I haz the power, 2015-09-29 16:28:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-29 16:30:37]

Patchset 2 (id:??) landed as
https://crrev.com/bd7cfd3aa45475b37ef095b8b5d91c03c2b39ac2
Cr-Commit-Position: refs/heads/master@{#351334}